Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 1789233002: Deprecate the generated element library and clean up imports (Closed)

Created:
4 years, 9 months ago by Brian Wilkerson
Modified:
4 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Deprecate the generated element library and clean up imports R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/93aa6f1ecf9fc3d9b9bcbdf03176459fb81e6275

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -79 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_hover.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/imported_reference_contributor.dart View 2 chunks +19 lines, -19 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/inherited_reference_contributor.dart View 2 chunks +28 lines, -27 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart View 2 chunks +33 lines, -31 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_dart.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 9 months ago (2016-03-12 16:40:09 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-03-12 16:50:24 UTC) #3
Brian Wilkerson
4 years, 9 months ago (2016-03-12 17:13:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
93aa6f1ecf9fc3d9b9bcbdf03176459fb81e6275 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698