Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1775)

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart

Issue 1789233002: Deprecate the generated element library and clean up imports (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart
index 9b36935fc04723cbb08ed41ff8eafa90c787a3c2..7f04c6b306d923dc10bfea4d65010eea39c47eb0 100644
--- a/pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart
+++ b/pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart
@@ -11,42 +11,14 @@ import 'package:analysis_server/src/services/completion/dart/completion_manager.
import 'package:analysis_server/src/services/completion/dart/optype.dart';
import 'package:analysis_server/src/services/completion/dart/suggestion_builder.dart'
show createSuggestion, ElementSuggestionBuilder;
-import 'package:analyzer/src/generated/element.dart';
+import 'package:analyzer/dart/element/element.dart';
+import 'package:analyzer/dart/element/type.dart';
+import 'package:analyzer/dart/element/visitor.dart';
import '../../../protocol_server.dart'
show CompletionSuggestion, CompletionSuggestionKind;
/**
- * A contributor for calculating suggestions for top level members
- * in the library in which the completion is requested
- * but outside the file in which the completion is requested.
- */
-class LocalLibraryContributor extends DartCompletionContributor {
- @override
- Future<List<CompletionSuggestion>> computeSuggestions(
- DartCompletionRequest request) async {
- if (!request.includeIdentifiers) {
- return EMPTY_LIST;
- }
-
- List<CompilationUnitElement> libraryUnits = await request.resolveUnits();
- if (libraryUnits == null) {
- return EMPTY_LIST;
- }
-
- OpType optype = (request as DartCompletionRequestImpl).opType;
- LibraryElementSuggestionBuilder visitor =
- new LibraryElementSuggestionBuilder(request, optype);
- for (CompilationUnitElement unit in libraryUnits) {
- if (unit != null && unit.source != request.source) {
- unit.accept(visitor);
- }
- }
- return visitor.suggestions;
- }
-}
-
-/**
* A visitor for building suggestions based upon the elements defined by
* a source file contained in the same library but not the same as
* the source in which the completions are being requested.
@@ -176,3 +148,33 @@ class LibraryElementSuggestionBuilder extends GeneralizingElementVisitor
}
}
}
+
+/**
+ * A contributor for calculating suggestions for top level members
+ * in the library in which the completion is requested
+ * but outside the file in which the completion is requested.
+ */
+class LocalLibraryContributor extends DartCompletionContributor {
+ @override
+ Future<List<CompletionSuggestion>> computeSuggestions(
+ DartCompletionRequest request) async {
+ if (!request.includeIdentifiers) {
+ return EMPTY_LIST;
+ }
+
+ List<CompilationUnitElement> libraryUnits = await request.resolveUnits();
+ if (libraryUnits == null) {
+ return EMPTY_LIST;
+ }
+
+ OpType optype = (request as DartCompletionRequestImpl).opType;
+ LibraryElementSuggestionBuilder visitor =
+ new LibraryElementSuggestionBuilder(request, optype);
+ for (CompilationUnitElement unit in libraryUnits) {
+ if (unit != null && unit.source != request.source) {
+ unit.accept(visitor);
+ }
+ }
+ return visitor.suggestions;
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698