[Offline pages] Making offline page bridge testable by junit

[Offline pages] Making offline page bridge testable by junit

* Creates a junit test: OfflinePageBridgeTest testing one method
  selected at random
* Makes necessary changes to make the method testable (making method
  called by native package visible, making constructor package visible,
  ensuring OfflinePageBridge is not final)

BUG=594252
Committed: https://crrev.com/377ed0be9fbb6010f256033a83e767d447961e93
Cr-Commit-Position: refs/heads/master@{#380788}

[fgorski, 2016-03-11 21:47:40]

fgorski@chromium.org changed reviewers:
+ bburns@chromium.org

[fgorski, 2016-03-11 21:47:41]

WDYT?

[bburns, 2016-03-11 22:07:54]

https://codereview.chromium.org/1788873003/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
(right):

https://codereview.chromium.org/1788873003/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java:48:
.nativeGetOfflineIdsForClientId(anyLong(), anyString(), anyString());
s/anyString()/eq("TEST_NAMESPACE")/
s/anystring()/eq("TEST_ID")/

https://codereview.chromium.org/1788873003/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java:54:
assertEquals(2, result.size());
insert verify(mBridge, times(1)).nativeGetOfflineIdsForClientId(...)

[fgorski, 2016-03-11 22:33:50]

addressed

https://codereview.chromium.org/1788873003/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
(right):

https://codereview.chromium.org/1788873003/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java:48:
.nativeGetOfflineIdsForClientId(anyLong(), anyString(), anyString());
On 2016/03/11 22:07:54, bburns wrote:
> s/anyString()/eq("TEST_NAMESPACE")/
> s/anystring()/eq("TEST_ID")/

Done.

https://codereview.chromium.org/1788873003/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java:54:
assertEquals(2, result.size());
On 2016/03/11 22:07:54, bburns wrote:
> insert verify(mBridge, times(1)).nativeGetOfflineIdsForClientId(...)

Done.

[bburns, 2016-03-11 23:01:10]

lgtm

[bburns, 2016-03-11 23:01:12]

lgtm

[fgorski, 2016-03-11 23:29:51]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2016-03-11 23:30:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1788873003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1788873003/20001

[commit-bot: I haz the power, 2016-03-11 23:55:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-11 23:57:03]

Description was changed from

==========
[Offline pages] Making offline page bridge testable by junit

* Creates a junit test: OfflinePageBridgeTest testing one method
  selected at random
* Makes necessary changes to make the method testable (making method
  called by native package visible, making constructor package visible,
  ensuring OfflinePageBridge is not final)

BUG=594252
==========

to

==========
[Offline pages] Making offline page bridge testable by junit

* Creates a junit test: OfflinePageBridgeTest testing one method
  selected at random
* Makes necessary changes to make the method testable (making method
  called by native package visible, making constructor package visible,
  ensuring OfflinePageBridge is not final)

BUG=594252

Committed: https://crrev.com/377ed0be9fbb6010f256033a83e767d447961e93
Cr-Commit-Position: refs/heads/master@{#380788}
==========

[commit-bot: I haz the power, 2016-03-11 23:57:04]

Patchset 2 (id:??) landed as
https://crrev.com/377ed0be9fbb6010f256033a83e767d447961e93
Cr-Commit-Position: refs/heads/master@{#380788}