Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

Issue 1788873003: [Offline pages] Making offline page bridge testable by junit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing feedback Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
index ebda57ff723507ae1d098d500a48f8ec882686a5..be9e2e646a06f8eaf5ff75d411bd2a52b60897c5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
@@ -26,7 +26,7 @@ import java.util.Set;
* Access gate to C++ side offline pages functionalities.
*/
@JNINamespace("offline_pages::android")
-public final class OfflinePageBridge {
+public class OfflinePageBridge {
public static final String BOOKMARK_NAMESPACE = "bookmark";
public static final long INVALID_OFFLINE_ID = 0;
@@ -167,8 +167,9 @@ public final class OfflinePageBridge {
/**
* Creates an offline page bridge for a given profile.
+ * Accessible by the package for testability.
*/
- private OfflinePageBridge(long nativeOfflinePageBridge) {
+ OfflinePageBridge(long nativeOfflinePageBridge) {
mNativeOfflinePageBridge = nativeOfflinePageBridge;
}
@@ -236,7 +237,7 @@ public final class OfflinePageBridge {
* @return A list of all offline ids that match a particular
* (namespace, client_id)
*/
- private Set<Long> getOfflineIdsForClientId(ClientId clientId) {
+ Set<Long> getOfflineIdsForClientId(ClientId clientId) {
assert mIsNativeOfflinePageModelLoaded;
long[] offlineIds = nativeGetOfflineIdsForClientId(
mNativeOfflinePageBridge, clientId.getNamespace(), clientId.getId());
@@ -482,7 +483,7 @@ public final class OfflinePageBridge {
}
@CalledByNative
- private void offlinePageModelLoaded() {
+ void offlinePageModelLoaded() {
mIsNativeOfflinePageModelLoaded = true;
for (OfflinePageModelObserver observer : mObservers) {
observer.offlinePageModelLoaded();
@@ -538,7 +539,7 @@ public final class OfflinePageBridge {
private native void nativeGetAllPages(
long nativeOfflinePageBridge, List<OfflinePageItem> offlinePages);
- private native long[] nativeGetOfflineIdsForClientId(
+ protected native long[] nativeGetOfflineIdsForClientId(
long nativeOfflinePageBridge, String clientNamespace, String clientId);
private native OfflinePageItem nativeGetPageByOfflineId(
long nativeOfflinePageBridge, long offlineId);
« no previous file with comments | « no previous file | chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698