Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1788743002: When not writing to file in DM, spew verbose output to stderr (Closed)

Created:
4 years, 9 months ago by egdaniel
Modified:
4 years, 9 months ago
Reviewers:
mtklein
CC:
reviews_skia.org, bsalomon
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M dm/DM.cpp View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
egdaniel
4 years, 9 months ago (2016-03-11 14:54:54 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1788743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1788743002/1
4 years, 9 months ago (2016-03-11 14:55:35 UTC) #5
mtklein
lgtm
4 years, 9 months ago (2016-03-11 15:02:42 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-11 15:13:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1788743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1788743002/1
4 years, 9 months ago (2016-03-11 15:13:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/40dec542cc12b354762bca2c0d68bc419f0cbebd
4 years, 9 months ago (2016-03-11 15:14:52 UTC) #12
mtklein
4 years, 9 months ago (2016-03-11 20:58:53 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1783603006/ by mtklein@google.com.

The reason for reverting is: Looks like not all the bots are using --writePath
(think, Valgrind, *SAN) so this causes those bots to spew like crazy.  

Looks like we need to find a more explicit way to make this mode work..

Powered by Google App Engine
This is Rietveld 408576698