Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: dm/DM.cpp

Issue 1788743002: When not writing to file in DM, spew verbose output to stderr (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DM.cpp
diff --git a/dm/DM.cpp b/dm/DM.cpp
index 2196e608036f1bcea1686a08b56389543981ca3b..f70d19e0aea3155de6d551df6fac37616cf40f82 100644
--- a/dm/DM.cpp
+++ b/dm/DM.cpp
@@ -1303,9 +1303,13 @@ int dm_main();
int dm_main() {
setup_crash_handler();
- if (FLAGS_verbose && !FLAGS_writePath.isEmpty()) {
- sk_mkdir(FLAGS_writePath[0]);
- gVLog = freopen(SkOSPath::Join(FLAGS_writePath[0], "verbose.log").c_str(), "w", stderr);
+ if (FLAGS_verbose) {
+ if(!FLAGS_writePath.isEmpty()) {
+ sk_mkdir(FLAGS_writePath[0]);
+ gVLog = freopen(SkOSPath::Join(FLAGS_writePath[0], "verbose.log").c_str(), "w", stderr);
+ } else {
+ gVLog = stderr;
+ }
}
JsonWriter::DumpJson(); // It's handy for the bots to assume this is ~never missing.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698