Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1788673004: Index unqualified unresolved used names. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Index unqualified unresolved used names. This fixes one of the previously disabled tests. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/222a11c29054edab144b1e7b6a875e03beb7e248

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -78 lines) Patch
M pkg/analysis_server/lib/src/services/index2/index2.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/element_references_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/index2/index2_test.dart View 4 chunks +80 lines, -30 lines 0 comments Download
M pkg/analysis_server/test/services/search/search_engine2_test.dart View 2 chunks +75 lines, -21 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 10 chunks +32 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View Binary file 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/index_unit.dart View 8 chunks +20 lines, -12 lines 1 comment Download
M pkg/analyzer/test/src/summary/index_unit_test.dart View 4 chunks +34 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 9 months ago (2016-03-11 22:43:29 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/1788673004/diff/1/pkg/analyzer/lib/src/summary/index_unit.dart File pkg/analyzer/lib/src/summary/index_unit.dart (right): https://codereview.chromium.org/1788673004/diff/1/pkg/analyzer/lib/src/summary/index_unit.dart#newcode47 pkg/analyzer/lib/src/summary/index_unit.dart:47: print(offset); Debugging code?
4 years, 9 months ago (2016-03-11 22:50:07 UTC) #2
scheglov
4 years, 9 months ago (2016-03-11 23:10:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
222a11c29054edab144b1e7b6a875e03beb7e248 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698