Index unqualified unresolved used names.

pkg/analyzer/test/src/summary/index_unit_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:convert';
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/src/summary/format.dart';
 import 'package:analyzer/src/summary/idl.dart';
@@ skipping 893 matching lines @@
     verifyNoTestUnitErrors = false;
     _indexTestUnit('''
 main(p) {
   p.x;
   p.x = 1;
   p.x += 2;
   p.x();
 }
 ''');
     assertThatName('x')
-      ..isUsed('x;', IndexRelationKind.IS_READ_BY)
-      ..isUsed('x = 1;', IndexRelationKind.IS_WRITTEN_BY)
-      ..isUsed('x += 2;', IndexRelationKind.IS_READ_WRITTEN_BY)
-      ..isUsed('x();', IndexRelationKind.IS_INVOKED_BY);
+      ..isUsedQ('x;', IndexRelationKind.IS_READ_BY)
+      ..isUsedQ('x = 1;', IndexRelationKind.IS_WRITTEN_BY)
+      ..isUsedQ('x += 2;', IndexRelationKind.IS_READ_WRITTEN_BY)
+      ..isUsedQ('x();', IndexRelationKind.IS_INVOKED_BY);
   }
 
-  void test_usedName_unqualified() {
+  void test_usedName_unqualified_resolved() {
     verifyNoTestUnitErrors = false;
     _indexTestUnit('''
 class C {
   var x;
+  m() {
+    x;
+    x = 1;
+    x += 2;
+    x();
+  }
 }
+''');
+    assertThatName('x')
+      ..isNotUsed('x;', IndexRelationKind.IS_READ_BY)
+      ..isNotUsed('x = 1;', IndexRelationKind.IS_WRITTEN_BY)
+      ..isNotUsed('x += 2;', IndexRelationKind.IS_READ_WRITTEN_BY)
+      ..isNotUsed('x();', IndexRelationKind.IS_INVOKED_BY);
+  }
+
+  void test_usedName_unqualified_unresolved() {
+    verifyNoTestUnitErrors = false;
+    _indexTestUnit('''
 main() {
   x;
   x = 1;
   x += 2;
   x();
 }
 ''');
     assertThatName('x')
-      ..isNotUsed('x;', IndexRelationKind.IS_READ_BY)
-      ..isNotUsed('x = 1;', IndexRelationKind.IS_WRITTEN_BY)
-      ..isNotUsed('x += 2;', IndexRelationKind.IS_READ_WRITTEN_BY)
-      ..isNotUsed('x();', IndexRelationKind.IS_INVOKED_BY);
+      ..isUsed('x;', IndexRelationKind.IS_READ_BY)
+      ..isUsed('x = 1;', IndexRelationKind.IS_WRITTEN_BY)
+      ..isUsed('x += 2;', IndexRelationKind.IS_READ_WRITTEN_BY)
+      ..isUsed('x();', IndexRelationKind.IS_INVOKED_BY);
   }
 
   void _assertDefinedName(String name, IndexNameKind kind, String search) {
     int offset = findOffset(search);
     int nameId = _getStringId(name);
     for (int i = 0; i < unitIndex.definedNames.length; i++) {
       if (unitIndex.definedNames[i] == nameId &&
           unitIndex.definedNameKinds[i] == kind &&
           unitIndex.definedNameOffsets[i] == offset) {
         return;
@@ skipping 21 matching lines @@
     _failWithIndexDump(
         'not found\n$element $expectedRelationKind at $expectedLocation');
   }
 
   void _assertUsedName(String name, IndexRelationKind kind,
       ExpectedLocation expectedLocation, bool isNot) {
     int nameId = _getStringId(name);
     for (int i = 0; i < unitIndex.usedNames.length; i++) {
       if (unitIndex.usedNames[i] == nameId &&
           unitIndex.usedNameKinds[i] == kind &&
-          unitIndex.usedNameOffsets[i] == expectedLocation.offset) {
+          unitIndex.usedNameOffsets[i] == expectedLocation.offset &&
+          unitIndex.usedNameIsQualifiedFlags[i] ==
+              expectedLocation.isQualified) {
         if (isNot) {
           _failWithIndexDump('Unexpected $name $kind at $expectedLocation');
         }
         return;
       }
     }
     if (isNot) {
       return;
     }
     _failWithIndexDump('Not found $name $kind at $expectedLocation');
@@ skipping 162 matching lines @@
 
   _NameIndexAssert(this.test, this.name);
 
   void isNotUsed(String search, IndexRelationKind kind) {
     test._assertUsedName(
         name, kind, test._expectedLocation(search, true), true);
   }
 
   void isUsed(String search, IndexRelationKind kind) {
     test._assertUsedName(
+        name, kind, test._expectedLocation(search, false), false);
+  }
+
+  void isUsedQ(String search, IndexRelationKind kind) {
+    test._assertUsedName(
         name, kind, test._expectedLocation(search, true), false);
   }
 }
 
 class _Relation {
   final IndexRelationKind kind;
   final int offset;
   final int length;
   final bool isQualified;
 
   _Relation(this.kind, this.offset, this.length, this.isQualified);
 
   @override
   String toString() {
     return '_Relation{kind: $kind, offset: $offset, length: $length, '
         'isQualified: $isQualified}';
   }
 }