Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5557)

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.cc

Issue 178863002: Implement settings in a widnow (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/translate/translate_bubble_view.cc
diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.cc b/chrome/browser/ui/views/translate/translate_bubble_view.cc
index b5a285befa35af1a3388c87b5ca698f26db580ee..705c882f765154d808361a7e0b49a393158c7a1a 100644
--- a/chrome/browser/ui/views/translate/translate_bubble_view.cc
+++ b/chrome/browser/ui/views/translate/translate_bubble_view.cc
@@ -18,6 +18,7 @@
#include "chrome/browser/translate/translate_manager.h"
#include "chrome/browser/translate/translate_tab_helper.h"
#include "chrome/browser/translate/translate_ui_delegate.h"
+#include "chrome/browser/ui/chrome_pages.h"
#include "chrome/browser/ui/translate/translate_bubble_model_impl.h"
#include "chrome/common/url_constants.h"
#include "components/translate/core/browser/translate_download_manager.h"
@@ -397,10 +398,9 @@ void TranslateBubbleView::HandleLinkClicked(
break;
}
case LINK_ID_LANGUAGE_SETTINGS: {
- std::string url = std::string(chrome::kChromeUISettingsURL) +
- chrome::kLanguageOptionsSubPage;
+ GURL url = chrome::GetSettingsUrl(chrome::kLanguageOptionsSubPage);
web_contents()->OpenURL(content::OpenURLParams(
- GURL(url),
+ url,
content::Referrer(),
NEW_FOREGROUND_TAB,
content::PAGE_TRANSITION_LINK,

Powered by Google App Engine
This is Rietveld 408576698