chrome/browser/ui/sync/one_click_signin_sync_starter.cc - Issue 178863002: Implement settings in a widnow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_starter.cc

Issue 178863002: Implement settings in a widnow (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/sync/one_click_signin_sync_starter.cc

diff --git a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc

index 7cded08d472b0a71995ae8101849e8e3e150667e..3caf6d39b7b9eb6b9f61c7331326b27d5193e49b 100644

--- a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc

+++ b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc

@@ -512,8 +512,8 @@ void OneClickSigninSyncStarter::FinishProfileSyncServiceSetup() {

void OneClickSigninSyncStarter::ShowSettingsPageInWebContents(

content::WebContents* contents,

const std::string& sub_page) {

- std::string url = std::string(chrome::kChromeUISettingsURL) + sub_page;

- content::OpenURLParams params(GURL(url),

+ GURL url = chrome::GetSettingsUrl(sub_page);

+ content::OpenURLParams params(url,

content::Referrer(),

CURRENT_TAB,

content::PAGE_TRANSITION_AUTO_TOPLEVEL,