Issue 1787433002: [Extensions] Harden against bindings interception

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1787433002: [Extensions] Harden against bindings interception (Closed)

Created:
4 years, 9 months ago by Devlin

Modified:
4 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

[Extensions] Harden against bindings interception There's more we can do but this is a start. BUG=590275 BUG=590118 Review URL: https://codereview.chromium.org/1748943002 Cr-Commit-Position: refs/heads/master@{#378621} (cherry picked from commit 75b803b1c81ed9fa5513cbff550232b4fb915e7b) Committed: https://chromium.googlesource.com/chromium/src/+/8a4fb2b8eea970c5a69ca00bf562c7803806af03

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+126 lines, -2 lines)			Patch
M	chrome/browser/extensions/extension_bindings_apitest.cc	View	1 chunk	+25 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/bindings/function_interceptions.html	View	1 chunk	+56 lines, -0 lines	0 comments	Download
M	extensions/renderer/module_system.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	extensions/renderer/v8_helpers.h	View	3 chunks	+43 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Devlin

4 years, 9 months ago (2016-03-10 22:55:09 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8a4fb2b8eea970c5a69ca00bf562c7803806af03.