extensions/renderer/module_system.cc - Issue 1787433002: [Extensions] Harden against bindings interception

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/module_system.cc

Issue 1787433002: [Extensions] Harden against bindings interception (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/module_system.cc

diff --git a/extensions/renderer/module_system.cc b/extensions/renderer/module_system.cc

index ef96d7360969d6df42adf5e7df1c77e90be996ed..f02741324ae3fd361d4e0fde487b6673d78f182c 100644

--- a/extensions/renderer/module_system.cc

+++ b/extensions/renderer/module_system.cc

@@ -251,12 +251,12 @@ v8::Local<v8::Value> ModuleSystem::RequireForJsInner(

v8::Local<v8::Object> modules(v8::Local<v8::Object>::Cast(modules_value));

v8::Local<v8::Value> exports;

- if (!GetProperty(v8_context, modules, module_name, &exports) ||

+ if (!GetPrivateProperty(v8_context, modules, module_name, &exports) ||

!exports->IsUndefined())

return handle_scope.Escape(exports);

exports = LoadModule(*v8::String::Utf8Value(module_name));

- SetProperty(v8_context, modules, module_name, exports);

+ SetPrivateProperty(v8_context, modules, module_name, exports);

return handle_scope.Escape(exports);

}