Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1786933002: Revert of [Extension UI Views] Add tests for clicking the different message bubble buttons (Closed)

Created:
4 years, 9 months ago by Will Harris
Modified:
4 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Extension UI Views] Add tests for clicking the different message bubble buttons (patchset #2 id:20001 of https://codereview.chromium.org/1768623002/ ) Reason for revert: this is breaking the win10 fyi bot see bug 594317 Original issue's description: > [Extension UI Views] Add tests for clicking the different message bubble buttons > > Add browser tests for clicking on the bubble's dismiss and action buttons, as > well as for focus loss. Regression tests for bug 590028. > > BUG=591572 > TBR=sky@chromium.org (settings_api_bubble_helper_views.cc, reviewed by Finnur) > > Committed: https://crrev.com/bd5c75db316b5fd049d5da855b8cedf15605f727 > Cr-Commit-Position: refs/heads/master@{#379627} TBR=asargent@chromium.org,finnur@chromium.org,rdevlin.cronin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=591572 Committed: https://crrev.com/2b7f84c4bcbd0bf31ef4db0051f9c522f8094ce0 Cr-Commit-Position: refs/heads/master@{#380857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -163 lines) Patch
M chrome/browser/ui/extensions/extension_message_bubble_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/extensions/extension_message_bubble_factory.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_message_bubble_view.h View 3 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_message_bubble_view.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc View 4 chunks +2 lines, -139 lines 0 comments Download
M chrome/browser/ui/views/settings_api_bubble_helper_views.cc View 4 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
Will Harris
Created Revert of [Extension UI Views] Add tests for clicking the different message bubble buttons
4 years, 9 months ago (2016-03-12 02:15:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1786933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1786933002/1
4 years, 9 months ago (2016-03-12 02:16:03 UTC) #2
Devlin
On 2016/03/12 02:16:03, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 9 months ago (2016-03-12 02:17:08 UTC) #3
Will Harris
On 2016/03/12 02:17:08, Devlin wrote: > On 2016/03/12 02:16:03, commit-bot: I haz the power wrote: ...
4 years, 9 months ago (2016-03-12 02:24:44 UTC) #4
Devlin
On 2016/03/12 02:24:44, Will Harris wrote: > On 2016/03/12 02:17:08, Devlin wrote: > > On ...
4 years, 9 months ago (2016-03-12 02:29:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1786933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1786933002/1
4 years, 9 months ago (2016-03-12 02:31:30 UTC) #6
Will Harris
On 2016/03/12 02:29:27, Devlin wrote: > On 2016/03/12 02:24:44, Will Harris wrote: > > On ...
4 years, 9 months ago (2016-03-12 02:32:49 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/158927)
4 years, 9 months ago (2016-03-12 02:45:34 UTC) #9
Will Harris
On 2016/03/12 02:45:34, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 9 months ago (2016-03-12 03:50:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1786933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1786933002/1
4 years, 9 months ago (2016-03-12 03:50:51 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-12 04:53:29 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-12 04:55:38 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b7f84c4bcbd0bf31ef4db0051f9c522f8094ce0
Cr-Commit-Position: refs/heads/master@{#380857}

Powered by Google App Engine
This is Rietveld 408576698