Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9072)

Unified Diff: chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

Issue 1786933002: Revert of [Extension UI Views] Add tests for clicking the different message bubble buttons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_message_bubble_view.cc
diff --git a/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc b/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc
index a3c156dd3fe94adcb845627c67b907d0659dff63..5b2f92016bf446f180f419b3a157a7737888156b 100644
--- a/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc
+++ b/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc
@@ -39,9 +39,6 @@
} // namespace
namespace extensions {
-
-ExtensionMessageBubbleView*
- ExtensionMessageBubbleView::active_bubble_for_testing_ = nullptr;
ExtensionMessageBubbleView::ExtensionMessageBubbleView(
views::View* anchor_view,
@@ -80,8 +77,6 @@
}
void ExtensionMessageBubbleView::OnWidgetDestroying(views::Widget* widget) {
- if (active_bubble_for_testing_ == this)
- active_bubble_for_testing_ = nullptr;
// To catch Esc, we monitor destroy message. Unless the link has been clicked,
// we assume Dismiss was the action taken.
if (!link_clicked_ && !action_taken_) {
@@ -101,7 +96,6 @@
ExtensionMessageBubbleView::~ExtensionMessageBubbleView() {}
void ExtensionMessageBubbleView::ShowBubble() {
- active_bubble_for_testing_ = this;
// Since we delay in showing the bubble, the applicable extension(s) may
// have been removed.
if (controller_->ShouldShow()) {

Powered by Google App Engine
This is Rietveld 408576698