Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1786733003: PushEvent.data should be NULL for empty payloads (Closed)

Created:
4 years, 9 months ago by Peter Beverloo
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

PushEvent.data should be NULL for empty payloads There was code in the PushEvent that would create an empty data object even when no data was available. Remove it, and add an end-to-end test. BUG=593454 Review URL: https://codereview.chromium.org/1784583002 Cr-Commit-Position: refs/heads/master@{#380258} (cherry picked from commit 72d7385fd0dfbd77ee41dd53cb0ef7ac16d118d7) Committed: https://chromium.googlesource.com/chromium/src/+/0ca7be84ec95b002d722b1c46acdc9d0e76242b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -39 lines) Patch
M chrome/browser/push_messaging/push_messaging_browsertest.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M chrome/test/data/push_messaging/service_worker.js View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/push_messaging/resources/pushmessagedata-worker.js View 1 chunk +3 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushEvent.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushMessageData.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Peter Beverloo
4 years, 9 months ago (2016-03-11 17:55:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0ca7be84ec95b002d722b1c46acdc9d0e76242b1.

Powered by Google App Engine
This is Rietveld 408576698