third_party/WebKit/Source/modules/push_messaging/PushMessageData.h - Issue 1786733003: PushEvent.data should be NULL for empty payloads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushMessageData.h

Issue 1786733003: PushEvent.data should be NULL for empty payloads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/push_messaging/PushMessageData.h

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushMessageData.h b/third_party/WebKit/Source/modules/push_messaging/PushMessageData.h

index 9861206a7d4945fd8f54ccad9df532e4d22a9b18..fffa8bd49c097cff757fd1be8e327a2a9be7bd82 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushMessageData.h

+++ b/third_party/WebKit/Source/modules/push_messaging/PushMessageData.h

@@ -24,10 +24,6 @@ class MODULES_EXPORT PushMessageData final : public GarbageCollectedFinalized<Pu

DEFINE_WRAPPERTYPEINFO();

public:

- static PushMessageData* create()

- {

- return new PushMessageData();

- }

static PushMessageData* create(const String& data);

static PushMessageData* create(const ArrayBufferOrArrayBufferViewOrUSVString& data);

@@ -41,7 +37,6 @@ public:

DECLARE_TRACE();

private:

- PushMessageData();

PushMessageData(const char* data, unsigned bytesSize);

Vector<char> m_data;