Oilpan: move WorkerGlobalScope to oilpan's heap.

Source/modules/notifications/WorkerGlobalScopeNotifications.h

Index: Source/modules/notifications/WorkerGlobalScopeNotifications.h
diff --git a/Source/modules/notifications/WorkerGlobalScopeNotifications.h b/Source/modules/notifications/WorkerGlobalScopeNotifications.h
index d62d35887a0876ac7400714dfeb7fdb3d85885a1..a89d19cde0a1343c769b02c8bb22c21291067320 100644
--- a/Source/modules/notifications/WorkerGlobalScopeNotifications.h
+++ b/Source/modules/notifications/WorkerGlobalScopeNotifications.h
@@ -38,21 +38,23 @@ class NotificationCenter;
 class ExecutionContext;
 class WorkerGlobalScope;
 
-class WorkerGlobalScopeNotifications FINAL : public WorkerSupplement {
+class WorkerGlobalScopeNotifications FINAL : public NoBaseWillBeGarbageCollectedFinalized<WorkerGlobalScopeNotifications>, public WorkerSupplement {
 public:
     virtual ~WorkerGlobalScopeNotifications();
 
     static NotificationCenter* webkitNotifications(WorkerGlobalScope&);
     static WorkerGlobalScopeNotifications& from(WorkerGlobalScope&);
 
+    virtual void trace(Visitor*);
+
 private:
-    explicit WorkerGlobalScopeNotifications(WorkerGlobalScope&);
+    explicit WorkerGlobalScopeNotifications(RawPtr<WorkerGlobalScope>);
 
     NotificationCenter* webkitNotifications();
     static const char* supplementName();
 
-    WorkerGlobalScope& m_context;
-    RefPtrWillBePersistent<NotificationCenter> m_notificationCenter;
+    RawPtrWillBeMember<WorkerGlobalScope> m_context;

[sof, 2014/02/26 12:26:05]

Note: changed this to be a raw-ptr/member instead of a ref.

[Mads Ager (chromium), 2014/02/26 13:09:08]

Yeah, I'm a bit unsure about these. We lose the clear indication that these
cannot be null which is bad. On the other hand, having a member is the right
thing to do for oilpan.

[sof, 2014/02/26 14:36:25]

Has the ability to declare const-like Members been considered?

[Mads Ager (chromium), 2014/02/26 15:10:19]

In principle you should be able to use 'const RefPtrWillBeMember' (if we have
correctly marked the right methods as const on Member and RefPtr). That alone
does not guarantee that it is non-null but then at least we can put an assert in
the constructor that it is not null.

+    RefPtrWillBeMember<NotificationCenter> m_notificationCenter;
 };
 
 } // namespace WebCore