Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: Source/modules/notifications/WorkerGlobalScopeNotifications.h

Issue 178663004: Oilpan: move WorkerGlobalScope to oilpan's heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make heap supplements actually be heap allocated Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/notifications/WorkerGlobalScopeNotifications.h
diff --git a/Source/modules/notifications/WorkerGlobalScopeNotifications.h b/Source/modules/notifications/WorkerGlobalScopeNotifications.h
index d62d35887a0876ac7400714dfeb7fdb3d85885a1..a89d19cde0a1343c769b02c8bb22c21291067320 100644
--- a/Source/modules/notifications/WorkerGlobalScopeNotifications.h
+++ b/Source/modules/notifications/WorkerGlobalScopeNotifications.h
@@ -38,21 +38,23 @@ class NotificationCenter;
class ExecutionContext;
class WorkerGlobalScope;
-class WorkerGlobalScopeNotifications FINAL : public WorkerSupplement {
+class WorkerGlobalScopeNotifications FINAL : public NoBaseWillBeGarbageCollectedFinalized<WorkerGlobalScopeNotifications>, public WorkerSupplement {
public:
virtual ~WorkerGlobalScopeNotifications();
static NotificationCenter* webkitNotifications(WorkerGlobalScope&);
static WorkerGlobalScopeNotifications& from(WorkerGlobalScope&);
+ virtual void trace(Visitor*);
+
private:
- explicit WorkerGlobalScopeNotifications(WorkerGlobalScope&);
+ explicit WorkerGlobalScopeNotifications(RawPtr<WorkerGlobalScope>);
NotificationCenter* webkitNotifications();
static const char* supplementName();
- WorkerGlobalScope& m_context;
- RefPtrWillBePersistent<NotificationCenter> m_notificationCenter;
+ RawPtrWillBeMember<WorkerGlobalScope> m_context;
sof 2014/02/26 12:26:05 Note: changed this to be a raw-ptr/member instead
Mads Ager (chromium) 2014/02/26 13:09:08 Yeah, I'm a bit unsure about these. We lose the cl
sof 2014/02/26 14:36:25 Has the ability to declare const-like Members been
Mads Ager (chromium) 2014/02/26 15:10:19 In principle you should be able to use 'const RefP
+ RefPtrWillBeMember<NotificationCenter> m_notificationCenter;
};
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698