Oilpan: move WorkerGlobalScope to oilpan's heap.

Source/modules/notifications/WorkerGlobalScopeNotifications.h

 /*
  * Copyright (C) 2008, 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 20 matching lines @@
 
 #include "core/workers/WorkerSupplementable.h"
 #include "heap/Handle.h"
 
 namespace WebCore {
 
 class NotificationCenter;
 class ExecutionContext;
 class WorkerGlobalScope;
 
-class WorkerGlobalScopeNotifications FINAL : public WorkerSupplement {
+class WorkerGlobalScopeNotifications FINAL : public NoBaseWillBeGarbageCollectedFinalized<WorkerGlobalScopeNotifications>, public WorkerSupplement {
 public:
     virtual ~WorkerGlobalScopeNotifications();
 
     static NotificationCenter* webkitNotifications(WorkerGlobalScope&);
     static WorkerGlobalScopeNotifications& from(WorkerGlobalScope&);
 
+    virtual void trace(Visitor*);
+
 private:
-    explicit WorkerGlobalScopeNotifications(WorkerGlobalScope&);
+    explicit WorkerGlobalScopeNotifications(RawPtr<WorkerGlobalScope>);
 
     NotificationCenter* webkitNotifications();
     static const char* supplementName();
 
-    WorkerGlobalScope& m_context;
-    RefPtrWillBePersistent<NotificationCenter> m_notificationCenter;
+    RawPtrWillBeMember<WorkerGlobalScope> m_context;

[sof, 2014/02/26 12:26:05]

Note: changed this to be a raw-ptr/member instead of a ref.

[Mads Ager (chromium), 2014/02/26 13:09:08]

Yeah, I'm a bit unsure about these. We lose the clear indication that these
cannot be null which is bad. On the other hand, having a member is the right
thing to do for oilpan.

[sof, 2014/02/26 14:36:25]

Has the ability to declare const-like Members been considered?

[Mads Ager (chromium), 2014/02/26 15:10:19]

In principle you should be able to use 'const RefPtrWillBeMember' (if we have
correctly marked the right methods as const on Member and RefPtr). That alone
does not guarantee that it is non-null but then at least we can put an assert in
the constructor that it is not null.

+    RefPtrWillBeMember<NotificationCenter> m_notificationCenter;
 };
 
 } // namespace WebCore
 
 #endif // WorkerGlobalScopeNotifications_h
 
 #endif // ENABLE(LEGACY_NOTIFICATIONS)