Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1786543002: Mojom parser: Stop populating the complete_typeset field. (Closed)

Created:
4 years, 9 months ago by rudominer
Modified:
4 years, 9 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mojom parser: Stop populating the complete_typeset field. The complete_typeset field is expensive to populate because it requires a depth-first search through the type graph rooted at each top-level interface. We originally thought this would be needed for runtime type information but it is currently not be used at all for that purpose. For now we are going to stop populating the field and add a comment that it is deprecated. We will likely remove it in the future. R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/efa10ff9d0829d4a5df0eab34364d7e117b85022

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -13 lines) Patch
M mojo/public/interfaces/bindings/mojom_types.mojom View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/mojom_tool/bin/linux64/mojom.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_tool/bin/mac64/mojom.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M mojom/mojom_parser/serialization/serialization.go View 4 chunks +19 lines, -6 lines 0 comments Download
M mojom/mojom_parser/serialization/serialization_test.go View 5 chunks +27 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
rudominer
Hi Alex, ptal.
4 years, 9 months ago (2016-03-11 01:54:43 UTC) #5
azani
lgtm
4 years, 9 months ago (2016-03-11 17:50:14 UTC) #6
rudominer
4 years, 9 months ago (2016-03-11 18:41:06 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:40001) manually as
efa10ff9d0829d4a5df0eab34364d7e117b85022 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698