Mojom parser: Stop populating the complete_typeset field.

mojom/mojom_parser/serialization/serialization_test.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package serialization
 
 import (
         "bytes"
         "compress/gzip"
         "encoding/base64"
@@ skipping 989 matching lines @@
                 // Simulate setting the canonical file name for the imported files. In real operation
                 // this step is done in parser_driver.go when each of the imported files are parsed.
                 mojomFile := parser.GetMojomFile()
                 if mojomFile.Imports != nil {
                         for _, imp := range mojomFile.Imports {
                                 imp.CanonicalFileName = fmt.Sprintf("%s.canonical", imp.SpecifiedName)
                         }
                 }
 
                 // Serialize
-                bytes, _, err := serialize(descriptor, false, c.lineAndcolumnNumbers, false)
+                bytes, _, err := serialize(descriptor, false, c.lineAndcolumnNumbers, false, false)
                 if err != nil {
                         t.Errorf("Serialization error for %s: %s", c.fileName, err.Error())
                         continue
                 }
 
                 // Serialize again and check for consistency.
-                bytes2, _, err := serialize(descriptor, false, c.lineAndcolumnNumbers, false)
+                bytes2, _, err := serialize(descriptor, false, c.lineAndcolumnNumbers, false, false)
                 if err != nil {
                         t.Errorf("Serialization error for %s: %s", c.fileName, err.Error())
                         continue
                 }
 
                 if !reflect.DeepEqual(bytes, bytes2) {
                         t.Errorf("Inconsistent serialization for %s:\nbytes=%v\nbytes2=%v\n",
                                 c.fileName, bytes, bytes2)
                         continue
                 }
@@ skipping 76 matching lines @@
                 if err := descriptor.ComputeEnumValueIntegers(); err != nil {
                         t.Errorf("ComputeEnumValueIntegers error for %s: %s", c.fileName, err.Error())
                         continue
                 }
                 if err := descriptor.ComputeDataForGenerators(); err != nil {
                         t.Errorf("ComputeDataForGenerators error for %s: %s", c.fileName, err.Error())
                         continue
                 }
 
                 // Serialize
-                bytes, _, err := serialize(descriptor, false, c.lineAndcolumnNumbers, false)
+                bytes, _, err := serialize(descriptor, false, c.lineAndcolumnNumbers, false, false)
                 if err != nil {
                         t.Errorf("Serialization error for %s: %s", c.fileName, err.Error())
                         continue
                 }
 
                 // Deserialize
                 decoder := bindings.NewDecoder(bytes, nil)
                 fileGraph := mojom_files.MojomFileGraph{}
                 fileGraph.Decode(decoder)
 
@@ skipping 258 matching lines @@
                 if err := descriptor.ComputeEnumValueIntegers(); err != nil {
                         t.Errorf("ComputeEnumValueIntegers error for case %d: %s", i, err.Error())
                         continue
                 }
                 if err := descriptor.ComputeDataForGenerators(); err != nil {
                         t.Errorf("ComputeDataForGenerators error for case %d: %s", i, err.Error())
                         continue
                 }
 
                 // Serialize
-                bytes, _, err := serialize(descriptor, false, c.lineAndcolumnNumbers, false)
+                bytes, _, err := serialize(descriptor, false, c.lineAndcolumnNumbers, false, false)
                 if err != nil {
                         t.Errorf("Serialization error for case %d: %s", i, err.Error())
                         continue
                 }
 
                 // Deserialize
                 decoder := bindings.NewDecoder(bytes, nil)
                 fileGraph := mojom_files.MojomFileGraph{}
                 fileGraph.Decode(decoder)
 
@@ skipping 603 matching lines @@
                 if err := descriptor.ComputeEnumValueIntegers(); err != nil {
                         t.Errorf("ComputeEnumValueIntegers error for case %d: %s", i, err.Error())
                         continue
                 }
                 if err := descriptor.ComputeDataForGenerators(); err != nil {
                         t.Errorf("ComputeDataForGenerators error for case %d: %s", i, err.Error())
                         continue
                 }
 
                 // Serialize
-                bytes, _, err := serialize(descriptor, false, false, true)
+                bytes, _, err := serialize(descriptor, false, false, true, true)
                 if err != nil {
                         t.Errorf("Serialization error for case %d: %s", i, err.Error())
                         continue
                 }
 
                 // Deserialize
                 decoder := bindings.NewDecoder(bytes, nil)
                 fileGraph := mojom_files.MojomFileGraph{}
                 fileGraph.Decode(decoder)
 
                 // Deserialize  RuntimeTypeInfo A
                 runtimeTypeInfoA := deserializeRuntimeTypeInfo(*fileGraph.Files[fileNameA].SerializedRuntimeTypeInfo)
 
                 // Deserialize  RuntimeTypeInfo B
                 runtimeTypeInfoB := deserializeRuntimeTypeInfo(*fileGraph.Files[fileNameB].SerializedRuntimeTypeInfo)
 
                 // Compare A
                 if err := compareTwoGoObjects(c.expectedRuntimeTypeInfoA, &runtimeTypeInfoA); err != nil {
                         t.Errorf("case %d A:\n%s", i, err.Error())
                 }
 
                 // Compare B
                 if err := compareTwoGoObjects(c.expectedRuntimeTypeInfoB, &runtimeTypeInfoB); err != nil {
                         t.Errorf("case %d B:\n%s", i, err.Error())
                 }
+
+                // Test the parameter populateCompleteTypeSet. We set the final
+                // parameter to false.
+                bytes, _, err = serialize(descriptor, false, false, true, false)
+                if err != nil {
+                        t.Errorf("Serialization error for case %d: %s", i, err.Error())
+                        continue
+                }
+
+                // Deserialize
+                decoder = bindings.NewDecoder(bytes, nil)
+                fileGraph = mojom_files.MojomFileGraph{}
+                fileGraph.Decode(decoder)
+                runtimeTypeInfoA = deserializeRuntimeTypeInfo(*fileGraph.Files[fileNameA].SerializedRuntimeTypeInfo)
+
+                // Check that CompleteTypeSet has not been populated for any service.
+                for name, service := range runtimeTypeInfoA.ServicesByName {
+                        length := len(service.CompleteTypeSet)
+                        if length != 0 {
+                                t.Errorf("len(CompleteTypeSet)=%d for service=%q", length, name)
+                        }
+                }
         }
 }
 
 func deserializeRuntimeTypeInfo(base64String string) mojom_types.RuntimeTypeInfo {
         compressedBytes, err := base64.StdEncoding.DecodeString(base64String)
         if err != nil {
                 panic(fmt.Sprintf("Error while unencoding runtimeTypeInfo: %s", err.Error()))
         }
         reader, err2 := gzip.NewReader(bytes.NewBuffer(compressedBytes))
         if err2 != nil {
@@ skipping 40 matching lines @@
                         }
                         return fmt.Errorf("*****\nexpected=\n*****\n%q\n*****\nactual=\n*****\n%q\n*****\n"+
                                 "match failed at position %d: expected=\n*****\n%q\n******\nactual=\n*****\n%q\n******\n",
                                 expectedString, actualString, diffPos, mismatchExpected, mismatchActual)
                 } else {
                         return fmt.Errorf("expected != actual but the two printed equal.")
                 }
         }
         return nil
 }