Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 1786483002: Add DomKey&DomCode to fabricated keydown event if exists (Closed)

Created:
4 years, 9 months ago by chongz
Modified:
4 years, 9 months ago
Reviewers:
Shu Chen
CC:
chromium-reviews, nona+watch_chromium.org, James Su, shuchen+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DomKey&DomCode to fabricated keydown event if exists On French layout pressing dead key will start composition and InputMethodChromeOS will send a fabricated keydown event. According to spec keydown for dead key should have DomKey "Dead". (similar for DomCode) SPEC=https://w3c.github.io/uievents/#example-d2fc8767 BUG=593400 Committed: https://crrev.com/eeca8bf8113eaa50fb3aa59666192ef11dd0b574 Cr-Commit-Position: refs/heads/master@{#380966}

Patch Set 1 #

Patch Set 2 : Fix unit test #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M ui/base/ime/input_method_chromeos.cc View 1 chunk +4 lines, -1 line 3 comments Download
M ui/base/ime/input_method_chromeos_unittest.cc View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
chongz
Hi shuchen, can you take a look at this CL please? Thanks!
4 years, 9 months ago (2016-03-11 15:20:56 UTC) #2
Shu Chen
lgtm https://codereview.chromium.org/1786483002/diff/20001/ui/base/ime/input_method_chromeos.cc File ui/base/ime/input_method_chromeos.cc (right): https://codereview.chromium.org/1786483002/diff/20001/ui/base/ime/input_method_chromeos.cc#newcode367 ui/base/ime/input_method_chromeos.cc:367: event->time_stamp()); Can you please confirm whether the CJK ...
4 years, 9 months ago (2016-03-11 16:24:53 UTC) #3
Shu Chen
sorry, I meant not lgtm.
4 years, 9 months ago (2016-03-11 16:25:17 UTC) #4
chongz
https://codereview.chromium.org/1786483002/diff/20001/ui/base/ime/input_method_chromeos.cc File ui/base/ime/input_method_chromeos.cc (right): https://codereview.chromium.org/1786483002/diff/20001/ui/base/ime/input_method_chromeos.cc#newcode367 ui/base/ime/input_method_chromeos.cc:367: event->time_stamp()); On 2016/03/11 16:24:53, Shu Chen wrote: > Can ...
4 years, 9 months ago (2016-03-11 21:17:26 UTC) #5
Shu Chen
lgtm https://codereview.chromium.org/1786483002/diff/20001/ui/base/ime/input_method_chromeos.cc File ui/base/ime/input_method_chromeos.cc (right): https://codereview.chromium.org/1786483002/diff/20001/ui/base/ime/input_method_chromeos.cc#newcode367 ui/base/ime/input_method_chromeos.cc:367: event->time_stamp()); On 2016/03/11 21:17:26, chongz wrote: > On ...
4 years, 9 months ago (2016-03-14 01:32:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1786483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1786483002/20001
4 years, 9 months ago (2016-03-14 13:23:41 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-14 13:53:20 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 13:54:35 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eeca8bf8113eaa50fb3aa59666192ef11dd0b574
Cr-Commit-Position: refs/heads/master@{#380966}

Powered by Google App Engine
This is Rietveld 408576698