Add DomKey&DomCode to fabricated keydown event if exists

Add DomKey&DomCode to fabricated keydown event if exists

On French layout pressing dead key will start composition and
InputMethodChromeOS will send a fabricated keydown event.

According to spec keydown for dead key should have DomKey "Dead".
(similar for DomCode)

SPEC=https://w3c.github.io/uievents/#example-d2fc8767

BUG=593400
Committed: https://crrev.com/eeca8bf8113eaa50fb3aa59666192ef11dd0b574
Cr-Commit-Position: refs/heads/master@{#380966}

[chongz, 2016-03-11 15:20:55]

chongz@chromium.org changed reviewers:
+ shuchen@chromium.org

[chongz, 2016-03-11 15:20:56]

Hi shuchen, can you take a look at this CL please? Thanks!

[Shu Chen, 2016-03-11 16:24:53]

lgtm

https://codereview.chromium.org/1786483002/diff/20001/ui/base/ime/input_metho...
File ui/base/ime/input_method_chromeos.cc (right):

https://codereview.chromium.org/1786483002/diff/20001/ui/base/ime/input_metho...
ui/base/ime/input_method_chromeos.cc:367: event->time_stamp());
Can you please confirm whether the CJK input methods are impacted by this?

e.g. activate Chinese Pinyin input method, and type 'a' in an input field, the
JS 'keydown' event should have keyCode==229.

[Shu Chen, 2016-03-11 16:25:17]

sorry, I meant not lgtm.

[chongz, 2016-03-11 21:17:26]

https://codereview.chromium.org/1786483002/diff/20001/ui/base/ime/input_metho...
File ui/base/ime/input_method_chromeos.cc (right):

https://codereview.chromium.org/1786483002/diff/20001/ui/base/ime/input_metho...
ui/base/ime/input_method_chromeos.cc:367: event->time_stamp());
On 2016/03/11 16:24:53, Shu Chen wrote:
> Can you please confirm whether the CJK input methods are impacted by this?
> 
> e.g. activate Chinese Pinyin input method, and type 'a' in an input field, the
> JS 'keydown' event should have keyCode==229.

Sure, but can I have some help on how to include IME in my Chromium build? I'm
following the "simple chrome" guide
(http://www.chromium.org/chromium-os/how-tos-and-troubleshooting/building-chro...)
but it seems that there is no IME installed.

And in addition, may I know why would this CL affect IME? I'm only passing two
new attributes |DomCode| and |DomKey| but didn't change |keyCode|, and this
event will be sent to blink directly.

Please note that this CL is not related to http://crbug.com/593443.

[Shu Chen, 2016-03-14 01:32:18]

lgtm

https://codereview.chromium.org/1786483002/diff/20001/ui/base/ime/input_metho...
File ui/base/ime/input_method_chromeos.cc (right):

https://codereview.chromium.org/1786483002/diff/20001/ui/base/ime/input_metho...
ui/base/ime/input_method_chromeos.cc:367: event->time_stamp());
On 2016/03/11 21:17:26, chongz wrote:
> On 2016/03/11 16:24:53, Shu Chen wrote:
> > Can you please confirm whether the CJK input methods are impacted by this?
> > 
> > e.g. activate Chinese Pinyin input method, and type 'a' in an input field,
the
> > JS 'keydown' event should have keyCode==229.
> 
> Sure, but can I have some help on how to include IME in my Chromium build? I'm
> following the "simple chrome" guide
>
(http://www.chromium.org/chromium-os/how-tos-and-troubleshooting/building-chro...)
> but it seems that there is no IME installed.
> 
> And in addition, may I know why would this CL affect IME? I'm only passing two
> new attributes |DomCode| and |DomKey| but didn't change |keyCode|, and this
> event will be sent to blink directly.
> 
> Please note that this CL is not related to http://crbug.com/593443.

Ack. It makes sense.

[chongz, 2016-03-14 13:23:36]

The CQ bit was checked by chongz@chromium.org

[commit-bot: I haz the power, 2016-03-14 13:23:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1786483002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1786483002/20001

[commit-bot: I haz the power, 2016-03-14 13:53:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-14 13:54:34]

Description was changed from

==========
Add DomKey&DomCode to fabricated keydown event if exists

On French layout pressing dead key will start composition and
InputMethodChromeOS will send a fabricated keydown event.

According to spec keydown for dead key should have DomKey "Dead".
(similar for DomCode)

SPEC=https://w3c.github.io/uievents/#example-d2fc8767

BUG=593400
==========

to

==========
Add DomKey&DomCode to fabricated keydown event if exists

On French layout pressing dead key will start composition and
InputMethodChromeOS will send a fabricated keydown event.

According to spec keydown for dead key should have DomKey "Dead".
(similar for DomCode)

SPEC=https://w3c.github.io/uievents/#example-d2fc8767

BUG=593400

Committed: https://crrev.com/eeca8bf8113eaa50fb3aa59666192ef11dd0b574
Cr-Commit-Position: refs/heads/master@{#380966}
==========

[commit-bot: I haz the power, 2016-03-14 13:54:35]

Patchset 2 (id:??) landed as
https://crrev.com/eeca8bf8113eaa50fb3aa59666192ef11dd0b574
Cr-Commit-Position: refs/heads/master@{#380966}