Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: ui/base/ime/input_method_chromeos.cc

Issue 1786483002: Add DomKey&DomCode to fabricated keydown event if exists (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit test Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/base/ime/input_method_chromeos_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/input_method_chromeos.cc
diff --git a/ui/base/ime/input_method_chromeos.cc b/ui/base/ime/input_method_chromeos.cc
index d49c734a6c6c035f6a9fe9ee2f2da358a6b45c45..924c9cf968321b28c022dbe6553290bc3929d75f 100644
--- a/ui/base/ime/input_method_chromeos.cc
+++ b/ui/base/ime/input_method_chromeos.cc
@@ -361,7 +361,10 @@ void InputMethodChromeOS::ProcessFilteredKeyPressEvent(ui::KeyEvent* event) {
}
ui::KeyEvent fabricated_event(ET_KEY_PRESSED,
VKEY_PROCESSKEY,
- event->flags());
+ event->code(),
+ event->flags(),
+ event->GetDomKey(),
+ event->time_stamp());
Shu Chen 2016/03/11 16:24:53 Can you please confirm whether the CJK input metho
chongz 2016/03/11 21:17:26 Sure, but can I have some help on how to include I
Shu Chen 2016/03/14 01:32:17 Ack. It makes sense.
ignore_result(DispatchKeyEventPostIME(&fabricated_event));
if (fabricated_event.stopped_propagation())
event->StopPropagation();
« no previous file with comments | « no previous file | ui/base/ime/input_method_chromeos_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698