content/public/android/javatests/src/org/chromium/content/browser/ContentViewPopupZoomerTest.java - Issue 1786243003: Rename pollForCriteria to pollForTestThreadCriteria.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/ContentViewPopupZoomerTest.java

Issue 1786243003: Rename pollForCriteria to pollForTestThreadCriteria. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and update MediaRouterIntegrationTest.java Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/ContentViewScrollingTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/ContentViewPopupZoomerTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewPopupZoomerTest.java b/content/public/android/javatests/src/org/chromium/content/browser/ContentViewPopupZoomerTest.java

index 7c4445b30c838b28652b78721e38c373014b7d32..4d31c2bb5c408b0b4ab05cd30c378eec58d596ec 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewPopupZoomerTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/ContentViewPopupZoomerTest.java

@@ -89,13 +89,13 @@ public class ContentViewPopupZoomerTest extends ContentShellTestBase {

final ViewGroup view = viewCore.getContainerView();

// The popup should be hidden before the click.

- CriteriaHelper.pollForCriteria(new PopupShowingCriteria(view, false));

+ CriteriaHelper.pollInstrumentationThread(new PopupShowingCriteria(view, false));

// Once clicked, the popup should show up.

DOMUtils.clickNode(this, viewCore, "clickme");

- CriteriaHelper.pollForCriteria(new PopupShowingCriteria(view, true));

+ CriteriaHelper.pollInstrumentationThread(new PopupShowingCriteria(view, true));

// The shown popup should have valid dimensions eventually.

- CriteriaHelper.pollForCriteria(new PopupHasNonZeroDimensionsCriteria(view));

+ CriteriaHelper.pollInstrumentationThread(new PopupHasNonZeroDimensionsCriteria(view));

}