content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java - Issue 1786243003: Rename pollForCriteria to pollForTestThreadCriteria.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java

Issue 1786243003: Rename pollForCriteria to pollForTestThreadCriteria. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and update MediaRouterIntegrationTest.java Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/ContentViewPopupZoomerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java b/content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java

index 4ed740bc10f3c7b4defa6c74736069d0654e8898..e4a53a1654e7b895eca7dc6bfbe786ef22e28723 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java

@@ -52,7 +52,7 @@ public class ContentViewLocationTest extends ContentShellTestBase {

mJavascriptHelper.waitUntilHasValue();

assertEquals(0, Integer.parseInt(mJavascriptHelper.getJsonResultAndClear()));

- CriteriaHelper.pollForCriteria(new Criteria() {

+ CriteriaHelper.pollInstrumentationThread(new Criteria() {

@Override

public boolean isSatisfied() {

mJavascriptHelper.evaluateJavaScriptForTests(getWebContents(), "positionCount");

@@ -73,7 +73,7 @@ public class ContentViewLocationTest extends ContentShellTestBase {

}

private void ensureGeolocationRunning(final boolean running) throws Exception {

- CriteriaHelper.pollForCriteria(Criteria.equals(running, new Callable<Boolean>() {

+ CriteriaHelper.pollInstrumentationThread(Criteria.equals(running, new Callable<Boolean>() {

@Override

public Boolean call() {

return mMockLocationProvider.isRunning();