Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1194)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8JavaScriptCallFrame.cpp

Issue 1786243002: [DevTools] Move restartFrame and setCallFrameVariableValue to V8DebuggerAgent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dgozman-patch
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8JavaScriptCallFrame.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8JavaScriptCallFrame.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8JavaScriptCallFrame.cpp
index b68010019f4c8f5d9ef187b952179fb9828e8209..f38f84c6da32883a6876be01c90a27929dcf6411 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8JavaScriptCallFrame.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8JavaScriptCallFrame.cpp
@@ -99,29 +99,6 @@ void evaluateWithExceptionDetailsMethodCallback(const v8::FunctionCallbackInfo<v
info.GetReturnValue().Set(impl->evaluateWithExceptionDetails(info[0], info[1]));
}
-void restartMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
-{
- JavaScriptCallFrame* impl = V8JavaScriptCallFrame::unwrap(info.GetIsolate()->GetCurrentContext(), info.Holder());
- v8::MaybeLocal<v8::Value> result = impl->restart();
- v8::Local<v8::Value> value;
- if (result.ToLocal(&value))
- info.GetReturnValue().Set(value);
-}
-
-void setVariableValueMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
-{
- JavaScriptCallFrame* impl = V8JavaScriptCallFrame::unwrap(info.GetIsolate()->GetCurrentContext(), info.Holder());
- v8::Maybe<int32_t> maybeScopeIndex = info[0]->Int32Value(info.GetIsolate()->GetCurrentContext());
- if (maybeScopeIndex.IsNothing())
- return;
- int scopeIndex = maybeScopeIndex.FromJust();
- v8::MaybeLocal<v8::Value> result = impl->setVariableValue(scopeIndex, info[1], info[2]);
- v8::Local<v8::Value> value;
- if (result.ToLocal(&value))
- info.GetReturnValue().Set(value);
-
-}
-
void scopeTypeMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
JavaScriptCallFrame* impl = V8JavaScriptCallFrame::unwrap(info.GetIsolate()->GetCurrentContext(), info.Holder());
@@ -184,8 +161,6 @@ const JavaScriptCallFrameWrapper::V8AttributeConfiguration V8JavaScriptCallFrame
const JavaScriptCallFrameWrapper::V8MethodConfiguration V8JavaScriptCallFrameMethods[] = {
{"evaluateWithExceptionDetails", evaluateWithExceptionDetailsMethodCallback},
- {"restart", restartMethodCallback},
- {"setVariableValue", setVariableValueMethodCallback},
{"scopeType", scopeTypeMethodCallback},
{"scopeName", scopeNameMethodCallback},
{"scopeStartLocation", scopeStartLocationMethodCallback},

Powered by Google App Engine
This is Rietveld 408576698