Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1340)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

Issue 1786243002: [DevTools] Move restartFrame and setCallFrameVariableValue to V8DebuggerAgent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dgozman-patch
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
index 11a19cc9e7a92050d677d94b32f496205616a233..1424ccf1b1b14c066d5647adbacad6f97da69545 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
@@ -346,22 +346,6 @@ void V8InjectedScriptHost::evaluateWithExceptionDetailsCallback(const v8::Functi
v8SetReturnValue(info, wrappedResult);
}
-void V8InjectedScriptHost::setFunctionVariableValueCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
-{
- if (info.Length() < 4 || !info[0]->IsFunction() || !info[1]->IsInt32() || !info[2]->IsString())
- return;
-
- v8::Local<v8::Value> functionValue = info[0];
- int scopeIndex = info[1].As<v8::Int32>()->Value();
- String16 variableName = toProtocolStringWithTypeCheck(info[2]);
- v8::Local<v8::Value> newValue = info[3];
-
- InjectedScriptHost* host = V8InjectedScriptHost::unwrap(info.GetIsolate()->GetCurrentContext(), info.Holder());
- if (!host->debugger())
- return;
- v8SetReturnValue(info, host->debugger()->setFunctionVariableValue(functionValue, scopeIndex, variableName, newValue));
-}
-
static bool getFunctionLocation(const v8::FunctionCallbackInfo<v8::Value>& info, String16* scriptId, int* lineNumber, int* columnNumber)
{
if (info.Length() < 1 || !info[0]->IsFunction())
@@ -580,7 +564,6 @@ const InjectedScriptHostWrapper::V8MethodConfiguration V8InjectedScriptHostMetho
{"callFunction", V8InjectedScriptHost::callFunctionCallback},
{"suppressWarningsAndCallFunction", V8InjectedScriptHost::suppressWarningsAndCallFunctionCallback},
{"setNonEnumProperty", V8InjectedScriptHost::setNonEnumPropertyCallback},
- {"setFunctionVariableValue", V8InjectedScriptHost::setFunctionVariableValueCallback},
{"bind", V8InjectedScriptHost::bindCallback},
{"objectForId", V8InjectedScriptHost::objectForIdCallback},
{"idToObjectGroupName", V8InjectedScriptHost::idToObjectGroupNameCallback},

Powered by Google App Engine
This is Rietveld 408576698