Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

Issue 1786243002: [DevTools] Move restartFrame and setCallFrameVariableValue to V8DebuggerAgent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dgozman-patch
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js b/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
index 7ef304958172e253b1d22a5ce0062aca2488c932..8f2c0d91299a96a6ab2f70b5bf6524d02aefcce1 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
@@ -1048,8 +1048,13 @@ WebInspector.ScopeRemoteObject.prototype = {
*/
function wrappedCallback(properties, internalProperties)
{
- if (this._scopeRef && Array.isArray(properties))
+ if (this._scopeRef && Array.isArray(properties)) {
this._savedScopeProperties = properties.slice();
+ if (!this._scopeRef.callFrameId) {
+ for (var property of this._savedScopeProperties)
+ property.writable = false;
+ }
+ }
callback(properties, internalProperties);
}
@@ -1068,7 +1073,7 @@ WebInspector.ScopeRemoteObject.prototype = {
doSetObjectPropertyValue: function(result, argumentName, callback)
{
var name = /** @type {string} */ (argumentName.value);
- this._debuggerModel.setVariableValue(this._scopeRef.number, name, WebInspector.RemoteObject.toCallArgument(result), this._scopeRef.callFrameId, this._scopeRef.functionId, setVariableValueCallback.bind(this));
+ this._debuggerModel.setVariableValue(this._scopeRef.number, name, WebInspector.RemoteObject.toCallArgument(result), this._scopeRef.callFrameId, setVariableValueCallback.bind(this));
/**
* @param {string=} error
@@ -1094,17 +1099,14 @@ WebInspector.ScopeRemoteObject.prototype = {
};
/**
- * Either callFrameId or functionId (exactly one) must be defined.
* @constructor
* @param {number} number
* @param {string=} callFrameId
- * @param {string=} functionId
*/
-WebInspector.ScopeRef = function(number, callFrameId, functionId)
+WebInspector.ScopeRef = function(number, callFrameId)
{
this.number = number;
this.callFrameId = callFrameId;
- this.functionId = functionId;
}
/**
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js ('k') | third_party/WebKit/Source/devtools/protocol.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698