third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js - Issue 1786243002: [DevTools] Move restartFrame and setCallFrameVariableValue to V8DebuggerAgent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

Issue 1786243002: [DevTools] Move restartFrame and setCallFrameVariableValue to V8DebuggerAgent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dgozman-patch

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

index 98b2d78418741c7e2a719acad3ae717150c86fd7..6250aa19ec06fc7cb765ac53db351c9dac6f174f 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

@@ -808,12 +808,11 @@ WebInspector.DebuggerModel.prototype = {

* @param {string} variableName

* @param {!RuntimeAgent.CallArgument} newValue

* @param {string} callFrameId

- * @param {string} functionObjectId

* @param {function(string=)=} callback

- setVariableValue: function(scopeNumber, variableName, newValue, callFrameId, functionObjectId, callback)

+ setVariableValue: function(scopeNumber, variableName, newValue, callFrameId, callback)

{

- this._agent.setVariableValue(scopeNumber, variableName, newValue, callFrameId, functionObjectId, innerCallback);

+ this._agent.setVariableValue(scopeNumber, variableName, newValue, callFrameId, innerCallback);

/**

* @param {?Protocol.Error} error

@@ -1376,7 +1375,7 @@ WebInspector.DebuggerModel.Scope.prototype = {

var declarativeScope = this._type !== DebuggerAgent.ScopeType.With && this._type !== DebuggerAgent.ScopeType.Global;

if (declarativeScope)

- this._object = runtimeModel.createScopeRemoteObject(this._payload.object, new WebInspector.ScopeRef(this._ordinal, this._callFrame.id, undefined));

+ this._object = runtimeModel.createScopeRemoteObject(this._payload.object, new WebInspector.ScopeRef(this._ordinal, this._callFrame.id));

else

this._object = runtimeModel.createRemoteObject(this._payload.object);