Network errors, hide suggestions less relevant on mobile platforms

Network errors, hide suggestions less relevant on mobile platforms
+ Also fixes a bug where the proxy, firewall suggestion link opens an invalid URL.

BUG=591987, 584615
Committed: https://crrev.com/c70a5078f6305cc29ab8f5f8023979cdb8b42236
Cr-Commit-Position: refs/heads/master@{#381813}

[edwardjung, 2016-03-11 15:22:53]

Description was changed from

==========
Network errors, hide suggestions less relevant on mobile platforms

BUG=591987,584615
==========

to

==========
Network errors, hide suggestions less relevant on mobile platforms
+ Also fixes a bug where the proxy, firewall suggestion link opens an invalid
URL. 

BUG=591987,584615
==========

[edwardjung, 2016-03-11 18:13:07]

edwardjung@chromium.org changed reviewers:
+ ttuttle@chromium.org

[edwardjung, 2016-03-11 18:13:08]

Please take a look.

Thanks.

[edwardjung, 2016-03-14 10:37:27]

edwardjung@chromium.org changed reviewers:
+ mmenke@chromium.org
- ttuttle@chromium.org

[edwardjung, 2016-03-14 10:37:27]

mmenke, could you take a look. 

Thanks.

[mmenke, 2016-03-14 20:17:28]

https://codereview.chromium.org/1786113002/diff/1/components/error_page/commo...
File components/error_page/common/localized_error.cc (right):

https://codereview.chromium.org/1786113002/diff/1/components/error_page/commo...
components/error_page/common/localized_error.cc:688:
IDS_ERRORPAGES_SUGGESTION_CHECK_PROXY_ADDRESS_SUMMARY, false);
Should also remove these strings on mobile.

Not a huge amount of space, but it all adds up.

[edwardjung, 2016-03-15 13:06:48]

Removed the unused strings on mobile.

https://codereview.chromium.org/1786113002/diff/1/components/error_page/commo...
File components/error_page/common/localized_error.cc (right):

https://codereview.chromium.org/1786113002/diff/1/components/error_page/commo...
components/error_page/common/localized_error.cc:688:
IDS_ERRORPAGES_SUGGESTION_CHECK_PROXY_ADDRESS_SUMMARY, false);
On 2016/03/14 20:17:28, mmenke wrote:
> Should also remove these strings on mobile.
> 
> Not a huge amount of space, but it all adds up.

Done.

[mmenke, 2016-03-15 14:28:47]

LGTM

[edwardjung, 2016-03-15 14:58:34]

edwardjung@chromium.org changed reviewers:
+ jochen@chromium.org

[edwardjung, 2016-03-15 14:58:35]

jochen, 

Could you take a look at the grd files. Thanks.

[jochen (gone - plz use gerrit), 2016-03-15 20:30:42]

https://codereview.chromium.org/1786113002/diff/20001/components/components_g...
File components/components_google_chrome_strings.grd (right):

https://codereview.chromium.org/1786113002/diff/20001/components/components_g...
components/components_google_chrome_strings.grd:148: Allow Chrome to access the
network in your firewall or antivirus
why do we have chrome/chromium checked into strings instead of $PRODUCT_NAME or
whatever the grd macro is called?

https://codereview.chromium.org/1786113002/diff/20001/components/error_page_s...
File components/error_page_strings.grdp (right):

https://codereview.chromium.org/1786113002/diff/20001/components/error_page_s...
components/error_page_strings.grdp:490: <ph name="BEGIN_LINK">&lt;a
href="#buttons" onclick="javascript:toggleHelpBox()"&gt;</ph>Checking the proxy,
firewall, and DNS configuration<ph
name="END_LINK">&lt;/a&gt;<ex>&lt;/a&gt;</ex></ph>
why do you ned javascript: in front of the onclick handler?

[mmenke, 2016-03-15 20:34:00]

https://codereview.chromium.org/1786113002/diff/20001/components/components_g...
File components/components_google_chrome_strings.grd (right):

https://codereview.chromium.org/1786113002/diff/20001/components/components_g...
components/components_google_chrome_strings.grd:148: Allow Chrome to access the
network in your firewall or antivirus
On 2016/03/15 20:30:42, jochen wrote:
> why do we have chrome/chromium checked into strings instead of $PRODUCT_NAME
or
> whatever the grd macro is called?

Nouns inflect in various languages, so can't just swap them in.  Using
IDS_PRODUCT_NAME is an anti-pattern that can't be internationalized.

[edwardjung, 2016-03-16 10:40:05]

https://codereview.chromium.org/1786113002/diff/20001/components/error_page_s...
File components/error_page_strings.grdp (right):

https://codereview.chromium.org/1786113002/diff/20001/components/error_page_s...
components/error_page_strings.grdp:490: <ph name="BEGIN_LINK">&lt;a
href="#buttons" onclick="javascript:toggleHelpBox()"&gt;</ph>Checking the proxy,
firewall, and DNS configuration<ph
name="END_LINK">&lt;/a&gt;<ex>&lt;/a&gt;</ex></ph>
On 2016/03/15 20:30:42, jochen wrote:
> why do you ned javascript: in front of the onclick handler?

Fixed.

[jochen (gone - plz use gerrit), 2016-03-17 19:53:24]

lgtm

[edwardjung, 2016-03-17 20:17:18]

The CQ bit was checked by edwardjung@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-17 20:17:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1786113002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1786113002/40001

[commit-bot: I haz the power, 2016-03-17 21:15:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 21:15:25]

Dry run: This issue passed the CQ dry run.

[edwardjung, 2016-03-17 22:33:10]

The CQ bit was checked by edwardjung@chromium.org

[edwardjung, 2016-03-17 22:33:10]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1786113002/#ps40001
(title: "Remove surplus javascript: prefix from onclick handlers")

[commit-bot: I haz the power, 2016-03-17 22:33:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1786113002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1786113002/40001

[commit-bot: I haz the power, 2016-03-17 22:40:53]

Description was changed from

==========
Network errors, hide suggestions less relevant on mobile platforms
+ Also fixes a bug where the proxy, firewall suggestion link opens an invalid
URL. 

BUG=591987,584615
==========

to

==========
Network errors, hide suggestions less relevant on mobile platforms
+ Also fixes a bug where the proxy, firewall suggestion link opens an invalid
URL. 

BUG=591987,584615
==========

[commit-bot: I haz the power, 2016-03-17 22:40:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-17 22:41:56]

Description was changed from

==========
Network errors, hide suggestions less relevant on mobile platforms
+ Also fixes a bug where the proxy, firewall suggestion link opens an invalid
URL. 

BUG=591987,584615
==========

to

==========
Network errors, hide suggestions less relevant on mobile platforms
+ Also fixes a bug where the proxy, firewall suggestion link opens an invalid
URL.

BUG=591987,584615

Committed: https://crrev.com/c70a5078f6305cc29ab8f5f8023979cdb8b42236
Cr-Commit-Position: refs/heads/master@{#381813}
==========

[commit-bot: I haz the power, 2016-03-17 22:41:57]

Patchset 3 (id:??) landed as
https://crrev.com/c70a5078f6305cc29ab8f5f8023979cdb8b42236
Cr-Commit-Position: refs/heads/master@{#381813}