Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: third_party/WebKit/Source/core/editing/Selection.idl

Issue 1785663002: Make setBaseAndExtent's arguments non-optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use collapse() where possible (one test) Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/Selection.idl
diff --git a/third_party/WebKit/Source/core/editing/Selection.idl b/third_party/WebKit/Source/core/editing/Selection.idl
index ad3935ef6d06a10977bc7f40c62e6e3ced3cbfe2..19be361c58dc0cdc7ef4ef360c931ce40ae1450d 100644
--- a/third_party/WebKit/Source/core/editing/Selection.idl
+++ b/third_party/WebKit/Source/core/editing/Selection.idl
@@ -52,12 +52,9 @@
[MeasureAs=SelectionCollapseToEnd, RaisesException] void collapseToEnd();
[MeasureAs=SelectionExtend, RaisesException] void extend(Node node, optional long offset = 0);
// TODO(philipj): The arguments should be anchorNode, anchorOffset,
- // focusNode and focusOffset, and none of them are optional or nullable in
- // the spec.
- [MeasureAs=SelectionSetBaseAndExtent, RaisesException] void setBaseAndExtent([Default=Undefined] optional Node? baseNode,
- [Default=Undefined] optional long baseOffset,
- [Default=Undefined] optional Node? extentNode,
- [Default=Undefined] optional long extentOffset);
+ // focusNode and focusOffset, and none of them are nullable in the spec.
+ [MeasureAs=SelectionSetBaseAndExtent, RaisesException] void setBaseAndExtent(Node? baseNode, long baseOffset,
+ Node? extentNode, long extentOffset);
[MeasureAs=SelectionSelectAllChildren, RaisesException] void selectAllChildren(Node node);
[MeasureAs=SelectionDeleteDromDocument, CustomElementCallbacks] void deleteFromDocument();
[MeasureAs=SelectionContainsNode] boolean containsNode(Node node, optional boolean allowPartialContainment = false);
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698