Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

Issue 1785663002: Make setBaseAndExtent's arguments non-optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use collapse() where possible (one test) Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt ('k') | third_party/WebKit/Source/core/editing/Selection.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js
diff --git a/third_party/WebKit/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js b/third_party/WebKit/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js
index 472b66a60addee9824db6b2f4fb62984206277c5..a056201544aa384e594e52bc3d3bfcf4e6f9de9b 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js
+++ b/third_party/WebKit/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js
@@ -304,7 +304,7 @@ shouldBe("nonNumericPolicy('document.createRange().isPointInRange(document, x)')
shouldBe("nonNumericPolicy('getSelection().collapse(document, x)')", "'any type allowed'");
shouldBe("nonNumericPolicy('getSelection().setBaseAndExtent(document, x, document, 0)')", "'any type allowed'");
-shouldBe("nonNumericPolicy('getSelection().setBaseAndExtent(document, 0, document, x)')", "'any type allowed'");
+shouldBe("nonNumericPolicy('getSelection().setBaseAndExtent(document, 0, document, x)')", "'any type allowed (but not omitted)'");
shouldBe("nonNumericPolicy('getSelection().collapse(document, x)')", "'any type allowed'");
shouldBe("nonNumericPolicy('getSelection().extend(document, x)')", "'any type allowed'");
shouldBe("nonNumericPolicy('getSelection().getRangeAt(x)')", "'any type allowed (but not omitted)'");
@@ -397,7 +397,7 @@ Here are other examples of numeric types in function parameters and settable att
../../../../WebCore/html/HTMLInputElement.idl: attribute long tabIndex;
../../../../WebCore/html/HTMLInputElement.idl: attribute long selectionStart;
../../../../WebCore/html/HTMLInputElement.idl: attribute long selectionEnd;
-../../../../WebCore/html/HTMLLIElement.idl: attribute long value;
+../../../../WebCore/html/HTMLLIElement.idl: attribute long value;
../../../../WebCore/html/HTMLMediaElement.idl: attribute unsigned long playCount
../../../../WebCore/html/HTMLMediaElement.idl: attribute unsigned long currentLoop;
../../../../WebCore/html/HTMLObjectElement.idl: attribute long hspace;
@@ -429,13 +429,13 @@ Here are other examples of numeric types in function parameters and settable att
../../../../WebCore/html/CanvasRenderingContext2D.idl: attribute float shadowOffsetY;
../../../../WebCore/html/CanvasRenderingContext2D.idl: attribute float shadowBlur;
../../../../WebCore/html/HTMLMediaElement.idl: attribute float currentTime
-../../../../WebCore/html/HTMLMediaElement.idl: attribute float defaultPlaybackRate
-../../../../WebCore/html/HTMLMediaElement.idl: attribute float playbackRate
+../../../../WebCore/html/HTMLMediaElement.idl: attribute float defaultPlaybackRate
+../../../../WebCore/html/HTMLMediaElement.idl: attribute float playbackRate
../../../../WebCore/html/HTMLMediaElement.idl: attribute float start;
../../../../WebCore/html/HTMLMediaElement.idl: attribute float end;
../../../../WebCore/html/HTMLMediaElement.idl: attribute float loopStart;
../../../../WebCore/html/HTMLMediaElement.idl: attribute float loopEnd;
-../../../../WebCore/html/HTMLMediaElement.idl: attribute float volume
+../../../../WebCore/html/HTMLMediaElement.idl: attribute float volume
../../../../WebCore/svg/SVGAnimatedInteger.idl: attribute long baseVal
../../../../WebCore/svg/SVGElementInstanceList.idl: SVGElementInstance item(in unsigned long index);
@@ -459,14 +459,14 @@ Here are other examples of numeric types in function parameters and settable att
../../../../WebCore/svg/SVGSVGElement.idl: unsigned long suspendRedraw(in unsigned long maxWaitMilliseconds);
../../../../WebCore/svg/SVGSVGElement.idl: void unsuspendRedraw(in unsigned long suspendHandleId)
../../../../WebCore/svg/SVGTextContentElement.idl: long getNumberOfChars();
-../../../../WebCore/svg/SVGTextContentElement.idl: float getSubStringLength(in unsigned long offset,
+../../../../WebCore/svg/SVGTextContentElement.idl: float getSubStringLength(in unsigned long offset,
../../../../WebCore/svg/SVGTextContentElement.idl: in unsigned long length)
../../../../WebCore/svg/SVGTextContentElement.idl: SVGPoint getStartPositionOfChar(in unsigned long offset)
../../../../WebCore/svg/SVGTextContentElement.idl: SVGPoint getEndPositionOfChar(in unsigned long offset)
../../../../WebCore/svg/SVGTextContentElement.idl: SVGRect getExtentOfChar(in unsigned long offset)
../../../../WebCore/svg/SVGTextContentElement.idl: float getRotationOfChar(in unsigned long offset)
../../../../WebCore/svg/SVGTextContentElement.idl: long getCharNumAtPosition(in SVGPoint point);
-../../../../WebCore/svg/SVGTextContentElement.idl: void selectSubString(in unsigned long offset,
+../../../../WebCore/svg/SVGTextContentElement.idl: void selectSubString(in unsigned long offset,
../../../../WebCore/svg/SVGTextContentElement.idl: in unsigned long length)
../../../../WebCore/svg/SVGTransformList.idl: [Custom] SVGTransform getItem(in unsigned long index)
../../../../WebCore/svg/SVGTransformList.idl: [Custom] SVGTransform insertItemBefore(in SVGTransform item, in unsigned long index)
@@ -494,7 +494,7 @@ Here are other examples of numeric types in function parameters and settable att
../../../../WebCore/svg/SVGSVGElement.idl: float getCurrentTime();
../../../../WebCore/svg/SVGSVGElement.idl: void setCurrentTime(in float seconds);
../../../../WebCore/svg/SVGTextContentElement.idl: float getComputedTextLength();
-../../../../WebCore/svg/SVGTextContentElement.idl: float getSubStringLength(in unsigned long offset,
+../../../../WebCore/svg/SVGTextContentElement.idl: float getSubStringLength(in unsigned long offset,
../../../../WebCore/svg/SVGTextContentElement.idl: float getRotationOfChar(in unsigned long offset)
../../../../WebCore/svg/SVGTransform.idl: void setTranslate(in float tx, in float ty);
../../../../WebCore/svg/SVGTransform.idl: void setScale(in float sx, in float sy);
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt ('k') | third_party/WebKit/Source/core/editing/Selection.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698