third_party/WebKit/LayoutTests/fast/block/float/float-list-changed-before-layout-crash.html - Issue 1785663002: Make setBaseAndExtent's arguments non-optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/block/float/float-list-changed-before-layout-crash.html

Issue 1785663002: Make setBaseAndExtent's arguments non-optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use collapse() where possible (one test) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js ('k') | third_party/WebKit/LayoutTests/fast/css-generated-content/crash-selection-editing-removes-pseudo.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/block/float/float-list-changed-before-layout-crash.html

diff --git a/third_party/WebKit/LayoutTests/fast/block/float/float-list-changed-before-layout-crash.html b/third_party/WebKit/LayoutTests/fast/block/float/float-list-changed-before-layout-crash.html

index 0a5d32a6ff8fb4a53a53d3643071ee36b86041ba..70bc0a61a0e7758f563ba76b4d1750123db9d45d 100644

--- a/third_party/WebKit/LayoutTests/fast/block/float/float-list-changed-before-layout-crash.html

+++ b/third_party/WebKit/LayoutTests/fast/block/float/float-list-changed-before-layout-crash.html

@@ -6,7 +6,7 @@

}

#el1:nth-last-child(2n) {

display: table-header-group;

- }

+ }

#el2:first-child {

display: inline-table;

}

@@ -15,7 +15,7 @@

}

#el2 {

display: table-header-group;

- }

+ }

#el4 {

visibility: collapse;

}

@@ -24,7 +24,7 @@

}

#el5 {

display: table-header-group;

- }

+ }

#el6 {

-webkit-border-after: solid;

float: left;

@@ -64,7 +64,7 @@

el7.setAttribute('id','el7')

document.body.appendChild(el7)

document.designMode='on'

- window.getSelection().setBaseAndExtent(el3, 1)

+ window.getSelection().setBaseAndExtent(el3, 1, null, 0)

document.execCommand('InsertLineBreak')

document.execCommand('selectall')

document.execCommand('strikethrough')