third_party/WebKit/LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js - Issue 1785663002: Make setBaseAndExtent's arguments non-optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js

Issue 1785663002: Make setBaseAndExtent's arguments non-optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use collapse() where possible (one test) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/execCommand/apply-inline-style-to-element-with-no-renderer-crash.html ('k') | third_party/WebKit/LayoutTests/fast/block/float/float-list-changed-before-layout-crash.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js

diff --git a/third_party/WebKit/LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js b/third_party/WebKit/LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js

index d44f417b258c06a0f2d196af2b56e0e7a6265ced..e82d6ab8c81f6f675b7916b6189277e39728b27c 100644

--- a/third_party/WebKit/LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js

+++ b/third_party/WebKit/LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js

@@ -3,7 +3,7 @@ description("Test to check if setBaseAndExtent guard node with null owner docume

var sel = window.getSelection();

var docType = document.implementation.createDocumentType('c', null, null);

-sel.setBaseAndExtent(docType);

+sel.setBaseAndExtent(docType, 0, null, 0);

shouldBeNull("sel.anchorNode");

sel.setBaseAndExtent(null, 0, docType, 0);