third_party/WebKit/LayoutTests/editing/execCommand/apply-inline-style-to-element-with-no-renderer-crash.html - Issue 1785663002: Make setBaseAndExtent's arguments non-optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/editing/execCommand/apply-inline-style-to-element-with-no-renderer-crash.html

Issue 1785663002: Make setBaseAndExtent's arguments non-optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use collapse() where possible (one test) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/editing/execCommand/apply-inline-style-to-element-with-no-renderer-crash.html

diff --git a/third_party/WebKit/LayoutTests/editing/execCommand/apply-inline-style-to-element-with-no-renderer-crash.html b/third_party/WebKit/LayoutTests/editing/execCommand/apply-inline-style-to-element-with-no-renderer-crash.html

index 3cba805269a89cd4d3ebc00d0a24c1617f422277..1f0f5f22ae882946298164bb496ad131405dc49c 100644

--- a/third_party/WebKit/LayoutTests/editing/execCommand/apply-inline-style-to-element-with-no-renderer-crash.html

+++ b/third_party/WebKit/LayoutTests/editing/execCommand/apply-inline-style-to-element-with-no-renderer-crash.html

@@ -25,7 +25,7 @@ test(function() {

input=document.createElement('input');

textPath.parentNode.insertBefore(input, textPath);

- window.getSelection().setBaseAndExtent(input, 4);

+ window.getSelection().setBaseAndExtent(input, 4, null, 0);

document.designMode='on';

document.execCommand('Transpose');

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js » ('j') | no next file with comments »