components/gcm_driver/instance_id/instance_id_driver.h - Issue 1785613006: Make GCMDriver::GetInstanceIDHandler protected, to avoid misuse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/instance_id/instance_id_driver.h

Issue 1785613006: Make GCMDriver::GetInstanceIDHandler protected, to avoid misuse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address peter's nits Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/gcm_driver/instance_id/instance_id_android.cc ('k') | components/gcm_driver/instance_id/instance_id_driver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/instance_id/instance_id_driver.h

diff --git a/components/gcm_driver/instance_id/instance_id_driver.h b/components/gcm_driver/instance_id/instance_id_driver.h

index b7df4fce21e25d05f6cc6a730542793b81c8ec06..e006f0d38e215625188153941aec7be2c6511f4b 100644

--- a/components/gcm_driver/instance_id/instance_id_driver.h

+++ b/components/gcm_driver/instance_id/instance_id_driver.h

@@ -42,7 +42,10 @@ class InstanceIDDriver {

bool ExistsInstanceID(const std::string& app_id) const;

private:

- gcm::GCMDriver* gcm_driver_; // Not owned.

+ // Owned by GCMProfileServiceFactory, which is a dependency of

+ // InstanceIDProfileServiceFactory, which owns this.

+ gcm::GCMDriver* gcm_driver_;

std::map<std::string, scoped_ptr<InstanceID>> instance_id_map_;

DISALLOW_COPY_AND_ASSIGN(InstanceIDDriver);