Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Side by Side Diff: components/gcm_driver/instance_id/instance_id_driver.h

Issue 1785613006: Make GCMDriver::GetInstanceIDHandler protected, to avoid misuse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address peter's nits Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_GCM_DRIVER_INSTANCE_ID_INSTANCE_ID_DRIVER_H_ 5 #ifndef COMPONENTS_GCM_DRIVER_INSTANCE_ID_INSTANCE_ID_DRIVER_H_
6 #define COMPONENTS_GCM_DRIVER_INSTANCE_ID_INSTANCE_ID_DRIVER_H_ 6 #define COMPONENTS_GCM_DRIVER_INSTANCE_ID_INSTANCE_ID_DRIVER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 10
(...skipping 24 matching lines...) Expand all
35 35
36 // Removes the InstanceID when it is not longer needed, i.e. the app is being 36 // Removes the InstanceID when it is not longer needed, i.e. the app is being
37 // uninstalled. 37 // uninstalled.
38 void RemoveInstanceID(const std::string& app_id); 38 void RemoveInstanceID(const std::string& app_id);
39 39
40 // Returns true if the InstanceID for the given application has been created. 40 // Returns true if the InstanceID for the given application has been created.
41 // This is currently only used for testing purpose. 41 // This is currently only used for testing purpose.
42 bool ExistsInstanceID(const std::string& app_id) const; 42 bool ExistsInstanceID(const std::string& app_id) const;
43 43
44 private: 44 private:
45 gcm::GCMDriver* gcm_driver_; // Not owned. 45 // Owned by GCMProfileServiceFactory, which is a dependency of
46 // InstanceIDProfileServiceFactory, which owns this.
47 gcm::GCMDriver* gcm_driver_;
48
46 std::map<std::string, scoped_ptr<InstanceID>> instance_id_map_; 49 std::map<std::string, scoped_ptr<InstanceID>> instance_id_map_;
47 50
48 DISALLOW_COPY_AND_ASSIGN(InstanceIDDriver); 51 DISALLOW_COPY_AND_ASSIGN(InstanceIDDriver);
49 }; 52 };
50 53
51 } // namespace instance_id 54 } // namespace instance_id
52 55
53 #endif // COMPONENTS_GCM_DRIVER_INSTANCE_ID_INSTANCE_ID_DRIVER_H_ 56 #endif // COMPONENTS_GCM_DRIVER_INSTANCE_ID_INSTANCE_ID_DRIVER_H_
OLDNEW
« no previous file with comments | « components/gcm_driver/instance_id/instance_id_android.cc ('k') | components/gcm_driver/instance_id/instance_id_driver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698