Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: components/gcm_driver/gcm_driver_desktop.h

Issue 1785613006: Make GCMDriver::GetInstanceIDHandler protected, to avoid misuse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Simplify by removing provider Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_driver_desktop.h
diff --git a/components/gcm_driver/gcm_driver_desktop.h b/components/gcm_driver/gcm_driver_desktop.h
index a162df161397468776e909ca34bb305459e05b6c..4723ba3a0697ee41636881ad7378f0b790705794 100644
--- a/components/gcm_driver/gcm_driver_desktop.h
+++ b/components/gcm_driver/gcm_driver_desktop.h
@@ -60,7 +60,7 @@ class GCMDriverDesktop : public GCMDriver,
const scoped_refptr<base::SequencedTaskRunner>& blocking_task_runner);
~GCMDriverDesktop() override;
- // GCMDriver overrides:
+ // GCMDriver implementation:
void Shutdown() override;
void OnSignedIn() override;
void OnSignedOut() override;
@@ -85,27 +85,10 @@ class GCMDriverDesktop : public GCMDriver,
base::Time GetLastTokenFetchTime() override;
void SetLastTokenFetchTime(const base::Time& time) override;
void WakeFromSuspendForHeartbeat(bool wake) override;
- InstanceIDHandler* GetInstanceIDHandler() override;
+ InstanceIDHandler* GetInstanceIDHandlerInternal() override;
void AddHeartbeatInterval(const std::string& scope, int interval_ms) override;
void RemoveHeartbeatInterval(const std::string& scope) override;
- // InstanceIDHandler overrides:
- void GetToken(const std::string& app_id,
- const std::string& authorized_entity,
- const std::string& scope,
- const std::map<std::string, std::string>& options,
- const GetTokenCallback& callback) override;
- void DeleteToken(const std::string& app_id,
- const std::string& authorized_entity,
- const std::string& scope,
- const DeleteTokenCallback& callback) override;
- void AddInstanceIDData(const std::string& app_id,
- const std::string& instance_id,
- const std::string& extra_data) override;
- void RemoveInstanceIDData(const std::string& app_id) override;
- void GetInstanceIDData(const std::string& app_id,
- const GetInstanceIDDataCallback& callback) override;
-
// Exposed for testing purpose.
bool gcm_enabled() const { return gcm_enabled_; }
GCMChannelStatusSyncer* gcm_channel_status_syncer_for_testing() {
@@ -125,6 +108,23 @@ class GCMDriverDesktop : public GCMDriver,
GCMEncryptionProvider::DecryptionResult result)
override;
+ // InstanceIDHandler implementation:
+ void GetToken(const std::string& app_id,
+ const std::string& authorized_entity,
+ const std::string& scope,
+ const std::map<std::string, std::string>& options,
+ const GetTokenCallback& callback) override;
+ void DeleteToken(const std::string& app_id,
+ const std::string& authorized_entity,
+ const std::string& scope,
+ const DeleteTokenCallback& callback) override;
+ void AddInstanceIDData(const std::string& app_id,
+ const std::string& instance_id,
+ const std::string& extra_data) override;
+ void RemoveInstanceIDData(const std::string& app_id) override;
+ void GetInstanceIDData(const std::string& app_id,
+ const GetInstanceIDDataCallback& callback) override;
+
private:
class IOWorker;

Powered by Google App Engine
This is Rietveld 408576698