components/gcm_driver/gcm_driver.h - Issue 1785613006: Make GCMDriver::GetInstanceIDHandler protected, to avoid misuse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_driver.h

Issue 1785613006: Make GCMDriver::GetInstanceIDHandler protected, to avoid misuse (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplify by removing provider Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/gcm_driver/fake_gcm_driver.cc ('k') | components/gcm_driver/gcm_driver_android.h » ('j') | components/gcm_driver/gcm_driver_desktop_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/gcm_driver.h

diff --git a/components/gcm_driver/gcm_driver.h b/components/gcm_driver/gcm_driver.h

index c33890a3636664662d9f28d563aa4b26febb2161..1fefed9a2e4dd87543f0f7ce699982337d3ec00f 100644

--- a/components/gcm_driver/gcm_driver.h

+++ b/components/gcm_driver/gcm_driver.h

@@ -212,8 +212,8 @@ class GCMDriver {

// to send a heartbeat message.

virtual void WakeFromSuspendForHeartbeat(bool wake) = 0;

- // Supports InstanceID handling.

- virtual InstanceIDHandler* GetInstanceIDHandler() = 0;

+ // Supports InstanceID handling. Must only be used by instance_id::InstanceID.

Peter Beverloo 2016/03/10 21:11:23 // Supports InstanceID handling. Must only be used

johnme 2016/03/11 15:56:04 Done.

+ virtual InstanceIDHandler* GetInstanceIDHandlerInternal() = 0;

// Adds or removes a custom client requested heartbeat interval. If multiple

// components set that setting, the lowest setting will be used. If the