third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp - Issue 1785603002: TEXTAREA: Cutting last line without EOL should not remove the remaining EOL in the previous line.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

Issue 1785603002: TEXTAREA: Cutting last line without EOL should not remove the remaining EOL in the previous line. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove an ASSERT, update a comment Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp ('k') | third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

index d85b5ea29faf4bbdb4bc5de2ea969d8dad27770b..d9fce93cb4e0287efdb0195fa6061f18d8865a78 100644

--- a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

@@ -1313,6 +1313,11 @@ void ReplaceSelectionCommand::doApply(EditingState* editingState)

if (editingState->isAborted())

return;

setEndingSelection(createVisiblePosition(firstPositionInNode(newListItem.get())));

+ } else if (HTMLTextFormControlElement* textControl = enclosingTextFormControl(enclosingBlockElement)) {

+ insertNodeAfter(textControl->createPlaceholderBreakElement(), insertedNodes.lastLeafInserted(), editingState);

+ if (editingState->isAborted())

+ return;

+ setEndingSelection(createVisiblePosition(positionAfterNode(insertedNodes.lastLeafInserted())));

} else {

// Use a default paragraph element (a plain div) for the empty paragraph, using the last paragraph

// block's style seems to annoy users.