third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp - Issue 1785603002: TEXTAREA: Cutting last line without EOL should not remove the remaining EOL in the previous line.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

Issue 1785603002: TEXTAREA: Cutting last line without EOL should not remove the remaining EOL in the previous line. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove an ASSERT, update a comment Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

index ab934f989cef88fdb8438fb2723a6b11ecab012d..e067f8b2920980bdb42846b43162d82976726f0c 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

@@ -191,7 +191,7 @@ void InsertTextCommand::doApply(EditingState* editingState)

Position endPosition;

- if (m_text == "\t") {

+ if (m_text == "\t" && isRichlyEditablePosition(startPosition)) {

endPosition = insertTab(startPosition, editingState);

if (editingState->isAborted())

return;