Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1785563003: Refactor LinkHeaderTest to use parameterized tests. (Closed)

Created:
4 years, 9 months ago by Marijn Kruisselbrink
Modified:
4 years, 9 months ago
Reviewers:
Yoav Weiss
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor LinkHeaderTest to use parameterized tests. Using parameterized tests makes debugging test failures much easier as gtest can actually print which test failed. Committed: https://crrev.com/4fa4da10820bf24cc60e205c4e157320f6ab39ef Cr-Commit-Position: refs/heads/master@{#380481}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -148 lines) Patch
M third_party/WebKit/Source/core/loader/LinkHeaderTest.cpp View 2 chunks +172 lines, -148 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
Marijn Kruisselbrink
Doesn't change anything to the actual tests, just refactors them to make it easier to ...
4 years, 9 months ago (2016-03-10 20:00:00 UTC) #2
Yoav Weiss
On 2016/03/10 20:00:00, Marijn Kruisselbrink wrote: > Doesn't change anything to the actual tests, just ...
4 years, 9 months ago (2016-03-10 20:45:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785563003/1
4 years, 9 months ago (2016-03-10 20:55:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 22:42:57 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 22:43:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fa4da10820bf24cc60e205c4e157320f6ab39ef
Cr-Commit-Position: refs/heads/master@{#380481}

Powered by Google App Engine
This is Rietveld 408576698