Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1779253002: More minor cleanups for LinkHeaderTest. (Closed)

Created:
4 years, 9 months ago by Marijn Kruisselbrink
Modified:
4 years, 9 months ago
Reviewers:
Yoav Weiss
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cleanup-linkheader-tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More minor cleanups for LinkHeaderTest. - Move some test cases from CrossOrigin tests to Single tests, as they don't test anything cross origin related. - Add ASSERTs to make sure the correct number of headers is returned. - Fix bug exposed by adding those asserts. - Change other ASSERTs to EXPECTs to make debugging failing tests easier. Committed: https://crrev.com/bd46a15a345d8d3f2afaff9e1e7b098427f1f7dc Cr-Commit-Position: refs/heads/master@{#380515}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -20 lines) Patch
M third_party/WebKit/Source/core/loader/LinkHeader.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkHeaderTest.cpp View 5 chunks +23 lines, -20 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (10 generated)
Marijn Kruisselbrink
4 years, 9 months ago (2016-03-10 20:00:22 UTC) #2
Yoav Weiss
On 2016/03/10 20:00:22, Marijn Kruisselbrink wrote: LGTM
4 years, 9 months ago (2016-03-10 21:06:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779253002/1
4 years, 9 months ago (2016-03-10 22:45:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/179709)
4 years, 9 months ago (2016-03-10 23:29:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779253002/1
4 years, 9 months ago (2016-03-10 23:36:09 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/179780)
4 years, 9 months ago (2016-03-11 00:15:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779253002/1
4 years, 9 months ago (2016-03-11 00:18:13 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/179842)
4 years, 9 months ago (2016-03-11 00:52:09 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779253002/1
4 years, 9 months ago (2016-03-11 04:06:25 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 05:15:25 UTC) #19
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 05:16:47 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd46a15a345d8d3f2afaff9e1e7b098427f1f7dc
Cr-Commit-Position: refs/heads/master@{#380515}

Powered by Google App Engine
This is Rietveld 408576698