Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 178543007: Add new module for distance field generation. (Closed)

Created:
6 years, 9 months ago by jvanverth1
Modified:
6 years, 9 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add new module for distance field generation. This improves the speed over the previous method by 10x+, and makes using distance fields practical. BUG=skia:2173 Committed: http://code.google.com/p/skia/source/detail?r=13729 Committed: http://code.google.com/p/skia/source/detail?r=13740

Patch Set 1 #

Patch Set 2 : Start using new module #

Patch Set 3 : Distance fields kind of working #

Patch Set 4 : Working distance field code #

Patch Set 5 : Use distance squared; remove gradient array; other cleanups #

Patch Set 6 : Fix bug in distance initialization #

Patch Set 7 : Speed up by pre-calcing which pixels are edges #

Patch Set 8 : Cleanups before review #

Total comments: 4

Patch Set 9 : Fix absolute value #

Total comments: 7

Patch Set 10 : Address nits #

Patch Set 11 : Fix warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+473 lines, -750 lines) Patch
M gm/gmmain.cpp View 1 2 3 4 5 6 7 8 9 2 chunks +13 lines, -0 lines 0 comments Download
M gyp/core.gypi View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
D gyp/edtaa.gyp View 1 2 3 4 5 6 7 1 chunk +0 lines, -31 lines 0 comments Download
M gyp/gpu.gyp View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
A + src/core/SkDistanceFieldGen.h View 1 2 3 4 5 6 7 8 9 1 chunk +25 lines, -0 lines 0 comments Download
A + src/core/SkDistanceFieldGen.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +401 lines, -0 lines 0 comments Download
M src/gpu/GrTextStrike.cpp View 1 2 3 4 5 6 7 5 chunks +32 lines, -76 lines 0 comments Download
D third_party/edtaa/LICENSE View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/edtaa/edtaa3.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/edtaa/edtaa3func.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -586 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
jvanverth1
6 years, 9 months ago (2014-03-10 15:12:18 UTC) #1
robertphillips
drive by nits https://codereview.chromium.org/178543007/diff/130001/gm/gmmain.cpp File gm/gmmain.cpp (right): https://codereview.chromium.org/178543007/diff/130001/gm/gmmain.cpp#newcode2416 gm/gmmain.cpp:2416: if ((kGPU_Backend == config.fBackend)) { extra ...
6 years, 9 months ago (2014-03-10 15:48:10 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/178543007/diff/150001/src/core/SkDistanceFieldGen.cpp File src/core/SkDistanceFieldGen.cpp (right): https://codereview.chromium.org/178543007/diff/150001/src/core/SkDistanceFieldGen.cpp#newcode77 src/core/SkDistanceFieldGen.cpp:77: float temp = dx; feel free to ignore, ...
6 years, 9 months ago (2014-03-10 17:58:39 UTC) #3
jvanverth1
https://codereview.chromium.org/178543007/diff/150001/src/gpu/GrTextStrike.cpp File src/gpu/GrTextStrike.cpp (right): https://codereview.chromium.org/178543007/diff/150001/src/gpu/GrTextStrike.cpp#newcode324 src/gpu/GrTextStrike.cpp:324: sk_bzero(dfStorage.get(), dfSize); On 2014/03/10 17:58:41, bsalomon wrote: > We ...
6 years, 9 months ago (2014-03-10 18:16:21 UTC) #4
jvanverth1
https://codereview.chromium.org/178543007/diff/130001/gm/gmmain.cpp File gm/gmmain.cpp (right): https://codereview.chromium.org/178543007/diff/130001/gm/gmmain.cpp#newcode2416 gm/gmmain.cpp:2416: if ((kGPU_Backend == config.fBackend)) { On 2014/03/10 15:48:11, robertphillips ...
6 years, 9 months ago (2014-03-10 18:42:06 UTC) #5
jvanverth1
The CQ bit was checked by jvanverth@google.com
6 years, 9 months ago (2014-03-10 18:45:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/178543007/170001
6 years, 9 months ago (2014-03-10 18:45:35 UTC) #7
bungeman-skia
https://codereview.chromium.org/178543007/diff/150001/src/gpu/GrTextStrike.cpp File src/gpu/GrTextStrike.cpp (right): https://codereview.chromium.org/178543007/diff/150001/src/gpu/GrTextStrike.cpp#newcode324 src/gpu/GrTextStrike.cpp:324: sk_bzero(dfStorage.get(), dfSize); On 2014/03/10 18:16:22, JimVV wrote: > On ...
6 years, 9 months ago (2014-03-10 19:00:29 UTC) #8
commit-bot: I haz the power
Change committed as 13729
6 years, 9 months ago (2014-03-10 19:39:06 UTC) #9
hal.canary
A revert of this CL has been created in https://codereview.chromium.org/190753015/ by halcanary@google.com. The reason for ...
6 years, 9 months ago (2014-03-10 20:37:32 UTC) #10
jvanverth1
The CQ bit was checked by jvanverth@google.com
6 years, 9 months ago (2014-03-11 15:24:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/178543007/190001
6 years, 9 months ago (2014-03-11 15:24:55 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 15:57:50 UTC) #13
Message was sent while issue was closed.
Change committed as 13740

Powered by Google App Engine
This is Rietveld 408576698