Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1785323002: Move computeIntrinsicSizingInfo to LayoutReplaced (Closed)

Created:
4 years, 9 months ago by davve
Modified:
4 years, 9 months ago
Reviewers:
fs
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@move-computeIntrinsicSizingInfo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move computeIntrinsicSizingInfo to LayoutReplaced It's only used on replaced content anyway so having an empty LayoutBox implementation is pointless. Committed: https://crrev.com/0cea0f6700549a4459a613f68b97df710eabacca Cr-Commit-Position: refs/heads/master@{#381445}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -28 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutReplaced.h View 2 chunks +14 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutReplaced.cpp View 4 chunks +10 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1785123003 Patch 20001

Messages

Total messages: 10 (5 generated)
davve
4 years, 9 months ago (2016-03-11 13:37:26 UTC) #2
fs
lgtm "...so having an empty LayoutBox is pointless." ...empty LayoutBox implementation...? BUG=?
4 years, 9 months ago (2016-03-11 13:47:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785323002/1
4 years, 9 months ago (2016-03-16 12:01:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 13:29:49 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 13:31:23 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0cea0f6700549a4459a613f68b97df710eabacca
Cr-Commit-Position: refs/heads/master@{#381445}

Powered by Google App Engine
This is Rietveld 408576698