Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1785123003: Rework embeddedContentBox into embeddedReplacedContent (Closed)

Created:
4 years, 9 months ago by davve
Modified:
4 years, 9 months ago
Reviewers:
fs
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rework embeddedContentBox into embeddedReplacedContent In preparation for removing computeIntrinsicSizingInfo from LayoutBox and only have it on LayoutReplaced. Committed: https://crrev.com/1f6eed8e362f458537e8a95c1df27e38cdc9c334 Cr-Commit-Position: refs/heads/master@{#380902}

Patch Set 1 #

Patch Set 2 : Rebase #

Messages

Total messages: 26 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785123003/1
4 years, 9 months ago (2016-03-11 11:18:24 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/3511) ios_rel_device_gn on ...
4 years, 9 months ago (2016-03-11 11:20:51 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785123003/20001
4 years, 9 months ago (2016-03-11 13:21:28 UTC) #6
davve
Something that came up when trying to explain what's going on. Couldn't come up with ...
4 years, 9 months ago (2016-03-11 13:37:10 UTC) #9
fs
Makes sense to me, LGTM. "prepartion" -> "preparation" Drop BUG= or "fill it out".
4 years, 9 months ago (2016-03-11 13:47:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785123003/20001
4 years, 9 months ago (2016-03-11 14:11:53 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/129678)
4 years, 9 months ago (2016-03-11 15:40:31 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785123003/20001
4 years, 9 months ago (2016-03-11 15:50:57 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/129726)
4 years, 9 months ago (2016-03-11 17:34:24 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785123003/20001
4 years, 9 months ago (2016-03-13 17:52:32 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-13 19:52:07 UTC) #24
commit-bot: I haz the power
4 years, 9 months ago (2016-03-13 19:53:11 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f6eed8e362f458537e8a95c1df27e38cdc9c334
Cr-Commit-Position: refs/heads/master@{#380902}

Powered by Google App Engine
This is Rietveld 408576698