Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1785073002: Hide infobar container when Reader Mode is open (Closed)

Created:
4 years, 9 months ago by mdjones
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide infobar container when Reader Mode is open If the Reader Mode panel is anything above peeking then hide any infobars trying to show. The infobars will re-show once Reader Mode is peeking or hidden. BUG=564486 Committed: https://crrev.com/ab26b6681dde41b4141fef09decf9c4e930aee85 Cr-Commit-Position: refs/heads/master@{#380717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelBase.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java View 4 chunks +20 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mdjones
PTAL, this will allow me to remove those null checks in the event filter CL.
4 years, 9 months ago (2016-03-11 02:24:30 UTC) #2
pedro (no code reviews)
lgtm
4 years, 9 months ago (2016-03-11 19:27:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785073002/1
4 years, 9 months ago (2016-03-11 19:57:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 20:39:38 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 20:40:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab26b6681dde41b4141fef09decf9c4e930aee85
Cr-Commit-Position: refs/heads/master@{#380717}

Powered by Google App Engine
This is Rietveld 408576698