chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelBase.java - Issue 1785073002: Hide infobar container when Reader Mode is open

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelBase.java

Issue 1785073002: Hide infobar container when Reader Mode is open (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelBase.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelBase.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelBase.java

index 41c12ba0ced4cb04626a0d3a4287a9f8138ab20d..ac110e715a8f7c16f36d2631f524902e90c33343 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelBase.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelBase.java

@@ -328,7 +328,7 @@ abstract class OverlayPanelBase implements ContextualSearchPromoHost {

* @return Whether the Overlay Panel is opened. That is, whether it is EXPANDED or MAXIMIZED.

public boolean isPanelOpened() {

- return mPanelState == PanelState.EXPANDED || mPanelState == PanelState.MAXIMIZED;

+ return mHeight > mBarHeightPeeking;

}

/**

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java » ('j') | no next file with comments »