Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1049)

Issue 1785033005: Use bundle_data and create_bundle to add support for iOS app bundle. (Closed)

Created:
4 years, 9 months ago by jungshik at Google
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke, sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@m49
Target Ref:
refs/heads/chromium/m49
Visibility:
Public.

Description

Use bundle_data and create_bundle to add support for iOS app bundle. Cherry-pick 0c9a78092 to m49 branch. Original CL: https://codereview.chromium.org/1755473004/ BUG=297668 TBR=dpranke@chromium.org,sdefresne Committed: https://chromium.googlesource.com/chromium/deps/icu/+/6d3b55dfa17d9a597c064eeef7ceac18c73184b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M BUILD.gn View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jungshik at Google
4 years, 9 months ago (2016-03-11 20:42:28 UTC) #1
jungshik at Google
Committed patchset #1 (id:1) manually as 6d3b55dfa17d9a597c064eeef7ceac18c73184b7 (presubmit successful).
4 years, 9 months ago (2016-03-11 20:42:46 UTC) #3
jungshik at Google
On 2016/03/11 20:42:28, jshin (jungshik at google) wrote: For the future reference to sdefresne@, I ...
4 years, 9 months ago (2016-03-11 20:43:24 UTC) #4
Dirk Pranke
Why are we pushing this onto the M49 branch? We only need the ios changes ...
4 years, 9 months ago (2016-03-11 20:44:11 UTC) #5
jungshik at Google
4 years, 9 months ago (2016-03-11 21:05:22 UTC) #6
Message was sent while issue was closed.
On 2016/03/11 20:44:11, Dirk Pranke wrote:
> Why are we pushing this onto the M49 branch? We only need the ios changes on
> trunk ...

Just for the record (although I told Dirk offline):  My choice of the branch
name was confusing and unfortunate. 'm49' here had better been named 'icu54'. 
This revision will NOT be used in CHromium's M49 branch.  This will be used only
in Chrome's trunk.

Powered by Google App Engine
This is Rietveld 408576698