Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1784903003: Remove FEC from send path. (Closed)

Created:
4 years, 9 months ago by rjshade
Modified:
4 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Fan Yang
Base URL:
https://chromium.googlesource.com/chromium/src.git@114770052
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FEC from send path. Merge internal change: 115997404 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : Restore accidentally removed OnRttChanged call #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -2926 lines) Patch
M net/quic/quic_chromium_client_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_chromium_client_stream_test.cc View 6 chunks +5 lines, -7 lines 0 comments Download
M net/quic/quic_connection.h View 5 chunks +1 line, -13 lines 0 comments Download
M net/quic/quic_connection.cc View 1 12 chunks +2 lines, -61 lines 0 comments Download
M net/quic/quic_connection_test.cc View 15 chunks +9 lines, -571 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/quic_packet_creator.h View 13 chunks +13 lines, -127 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 24 chunks +26 lines, -271 lines 0 comments Download
M net/quic/quic_packet_creator_test.cc View 29 chunks +48 lines, -575 lines 0 comments Download
M net/quic/quic_packet_generator.h View 7 chunks +4 lines, -42 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 12 chunks +10 lines, -63 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 41 chunks +57 lines, -859 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +0 lines, -20 lines 0 comments Download
M net/quic/quic_session.h View 2 chunks +1 line, -5 lines 0 comments Download
M net/quic/quic_session.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/quic/quic_session_test.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M net/quic/quic_spdy_stream_test.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M net/quic/reliable_quic_stream.h View 3 chunks +0 lines, -9 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 4 chunks +4 lines, -13 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 18 chunks +32 lines, -121 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/quic/test_tools/quic_packet_creator_peer.h View 2 chunks +0 lines, -13 lines 0 comments Download
M net/quic/test_tools/quic_packet_creator_peer.cc View 3 chunks +1 line, -49 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 3 chunks +3 lines, -4 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/test_tools/reliable_quic_stream_peer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/test_tools/reliable_quic_stream_peer.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 14 chunks +14 lines, -15 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 2 chunks +0 lines, -6 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 3 chunks +0 lines, -12 lines 0 comments Download

Depends on Patchset:

Issue 1782053003 Patch 1

Dependent Patchsets:

Issue 1782143003 Patch 1

Messages

Total messages: 2 (0 generated)
rjshade
4 years, 9 months ago (2016-03-10 19:39:09 UTC) #1
Ryan Hamilton
4 years, 9 months ago (2016-03-10 22:34:42 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698