Remove FEC from send path.

net/quic/quic_packet_generator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Responsible for generating packets on behalf of a QuicConnection.
 // Packets are serialized just-in-time.  Control frames are queued.
 // Ack and Feedback frames will be requested from the Connection
 // just-in-time.  When a packet needs to be sent, the Generator
 // will serialize a packet and pass it to QuicConnection::SendOrQueuePacket()
 //
@@ skipping 18 matching lines @@
 // but has not been sent, then the Delegate will be asked to create
 // an Ack frame which will then be included in the packet.  When
 // the write call completes, the current packet will be serialized
 // and sent to the Delegate, even if it is not full.
 //
 // If the Generator is in batch mode, then each write operation will
 // add data to the "current" packet.  When the current packet becomes
 // full, it will be serialized and sent to the packet.  When batch
 // mode is ended via |FinishBatchOperations|, the current packet
 // will be serialzied, even if it is not full.
-//
-// FEC behavior also depends on batch mode.  In batch mode, FEC packets
-// will be sent after |max_packets_per_group| have been sent, as well
-// as after batch operations are complete.  When not in batch mode,
-// an FEC packet will be sent after each write call completes.
-//
-// TODO(rch): This behavior should probably be tuned.  When not in batch
-// mode, we should probably set a timer so that several independent
-// operations can be grouped into the same FEC group.
-//
-// When an FEC packet is generated, it will be send to the Delegate,
-// even if the Delegate has become unwritable after handling the
-// data packet immediately proceeding the FEC packet.
 
 #ifndef NET_QUIC_QUIC_PACKET_GENERATOR_H_
 #define NET_QUIC_QUIC_PACKET_GENERATOR_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <list>
 
 #include "base/macros.h"
@@ skipping 22 matching lines @@
   };
 
   QuicPacketGenerator(QuicConnectionId connection_id,
                       QuicFramer* framer,
                       QuicRandom* random_generator,
                       QuicBufferAllocator* buffer_allocator,
                       DelegateInterface* delegate);
 
   ~QuicPacketGenerator();
 
-  // Called by the connection in the event of the congestion window changing.
-  void OnCongestionWindowChange(QuicPacketCount max_packets_in_flight);
-
-  // Called by the connection when the RTT may have changed.
-  void OnRttChange(QuicTime::Delta rtt);
-
   // Indicates that an ACK frame should be sent.
   // If |also_send_stop_waiting| is true, then it also indicates that a
   // STOP_WAITING frame should be sent as well.
   // The contents of the frame(s) will be generated via a call to the delegate
   // CreateAckFrame() when the packet is serialized.
   void SetShouldSendAck(bool also_send_stop_waiting);
 
   void AddControlFrame(const QuicFrame& frame);
 
   // Given some data, may consume part or all of it and pass it to the
   // packet creator to be serialized into packets. If not in batch
   // mode, these packets will also be sent during this call.
   // |delegate| (if not nullptr) will be informed once all packets sent as a
   // result of this call are ACKed by the peer.
   QuicConsumedData ConsumeData(QuicStreamId id,
                                QuicIOVector iov,
                                QuicStreamOffset offset,
                                bool fin,
-                               FecProtection fec_protection,
                                QuicAckListenerInterface* listener);
 
   // Generates an MTU discovery packet of specified size.
   void GenerateMtuDiscoveryPacket(QuicByteCount target_mtu,
                                   QuicAckListenerInterface* listener);
 
   // Indicates whether batch mode is currently enabled.
   bool InBatchMode();
   // Disables flushing.
   void StartBatchOperations();
@@ skipping 10 matching lines @@
 
   // Creates a version negotiation packet which supports |supported_versions|.
   // Caller owns the created  packet. Also, sets the entropy hash of the
   // serialized packet to a random bool and returns that value as a member of
   // SerializedPacket.
   QuicEncryptedPacket* SerializeVersionNegotiationPacket(
       const QuicVersionVector& supported_versions);
 
   // Re-serializes frames with the original packet's packet number length.
   // Used for retransmitting packets to ensure they aren't too long.
-  // Caller must ensure that any open FEC group is closed before calling this
-  // method.
   void ReserializeAllFrames(const PendingRetransmission& retransmission,
                             char* buffer,
                             size_t buffer_len);
 
   // Update the packet number length to use in future packets as soon as it
   // can be safely changed.
   void UpdateSequenceNumberLength(QuicPacketNumber least_packet_awaited_by_peer,
                                   QuicPacketCount max_packets_in_flight);
 
   // Set the minimum number of bytes for the connection id length;
   void SetConnectionIdLength(uint32_t length);
 
-  // Called when the FEC alarm fires.
-  void OnFecTimeout();
-
-  // Called after sending |packet_number| to determine whether an FEC alarm
-  // should be set for sending out an FEC packet. Returns a positive and finite
-  // timeout if an FEC alarm should be set, and infinite if no alarm should be
-  // set. OnFecTimeout should be called to send the FEC packet when the alarm
-  // fires.
-  QuicTime::Delta GetFecTimeout(QuicPacketNumber packet_number);
-
   // Sets the encrypter to use for the encryption level.
   void SetEncrypter(EncryptionLevel level, QuicEncrypter* encrypter);
 
   // Sets the encryption level that will be applied to new packets.
   void set_encryption_level(EncryptionLevel level);
 
   // packet number of the last created packet, or 0 if no packets have been
   // created.
   QuicPacketNumber packet_number() const;
 
   // Returns the maximum packet length.  Note that this is the long-term maximum
   // packet length, and it may not be the maximum length of the current packet,
-  // if the generator is in the middle of the packet (in batch mode) or FEC
-  // group.
+  // if the generator is in the middle of the packet (in batch mode).
   QuicByteCount GetMaxPacketLength() const;
   // Returns the maximum length current packet can actually have.
   QuicByteCount GetCurrentMaxPacketLength() const;
 
   // Set maximum packet length sent.  If |force| is set to true, all pending
-  // unfinished packets and FEC groups are closed, and the change is enacted
-  // immediately.  Otherwise, it is enacted at the next opportunity.
+  // unfinished packets are closed, and the change is enacted immediately.
+  // Otherwise, it is enacted at the next opportunity.
   void SetMaxPacketLength(QuicByteCount length, bool force);
 
   // Sets |path_id| to be the path on which next packet is generated.
   void SetCurrentPath(QuicPathId path_id,
                       QuicPacketNumber least_packet_awaited_by_peer,
                       QuicPacketCount max_packets_in_flight);
 
   void set_debug_delegate(QuicPacketCreator::DebugDelegate* debug_delegate) {
     packet_creator_.set_debug_delegate(debug_delegate);
   }
 
-  void set_rtt_multiplier_for_fec_timeout(float rtt_multiplier_for_fec_timeout);
-
-  FecSendPolicy fec_send_policy();
-  void set_fec_send_policy(FecSendPolicy fec_send_policy);
-
  private:
   friend class test::QuicPacketGeneratorPeer;
 
-  void SendQueuedFrames(bool flush, bool is_fec_timeout);
+  void SendQueuedFrames(bool flush);
 
   // Test to see if we have pending ack, or control frames.
   bool HasPendingFrames() const;
   // Returns true if addition of a pending frame (which might be
   // retransmittable) would still allow the resulting packet to be sent now.
   bool CanSendWithNextPendingFrameAddition() const;
   // Add exactly one pending frame, preferring ack frames over control frames.
   // Returns true if a pending frame is successfully added.
   // Returns false and flushes current open packet if the pending frame cannot
   // fit into current open packet.
@@ skipping 21 matching lines @@
   // the maximum size we are actually using now, if we are in the middle of the
   // packet.
   QuicByteCount max_packet_length_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicPacketGenerator);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_QUIC_PACKET_GENERATOR_H_